Todo #1071
closed
Reevaluate locks
0%
Description
Since the change to the lock function in util.inc to make shared locks the default instead of exclusive locks, most locks have been effectively nonexistent (currently only the config library uses exclusive locking at all). Code that only reads and does not write can probably continue to use the shared locks, but code that does writing or is non-reentrant for any other reason should probably have the locks made exclusive (LOCK_EX).
Some places where this may need to be checked include captive portal, vouchers, and filter reload, but there may be others.
Updated by Ermal Luçi over 13 years ago
- Status changed from New to Feedback
The necessary places for re-evaluation of locks are completed.
If there are other areas this needs to be done post 2.0.
Updated by Ermal Luçi over 13 years ago
- Target version changed from 2.0 to Future
Most of what is necessary for 2.0 has been done.
I will leave this open for Future version for any other part that needs attention.
Updated by Chris Buechler over 10 years ago
- Status changed from Feedback to Closed