Project

General

Profile

Actions

Bug #1168

closed

Some description fields don't accept umlauts

Added by igor igor about 13 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
01/06/2011
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.0
Affected Architecture:

Description

Entering chars like umlauts in the description-fields of aliases, they are not shown later.
Entering umlauts in the description-fields of added Port-aliases, config will be immediately reset to an older version. This is really fatal.
Same with hosts as alias.

Actions #1

Updated by Jim Pingle about 13 years ago

The per-entry description field, internally called "detail", is not CDATA escaped like the main description field so it cannot take characters that are invalid in XML.

As for the main descr field, it seems on that page we use:

$alias['descr'] = mb_convert_encoding($_POST['descr'],"HTML-ENTITIES","auto");

Which seems to strip out certain chars, like those with umlauts. Not sure why we only use that in certain places (it only shows up 9 times in 5 pages).

etc/inc/easyrule.inc:169:               $alias['descr']   = mb_convert_encoding("Hosts blocked from Firewall Log view","HTML-ENTITIES","auto");
usr/local/www/firewall_aliases_edit.php:287:            $alias['descr'] = mb_convert_encoding($_POST['descr'],"HTML-ENTITIES","auto");
usr/local/www/firewall_aliases_edit.php:345:            $pconfig['descr'] = mb_convert_encoding($_POST['descr'],"HTML-ENTITIES","auto");
usr/local/www/interfaces_groups_edit.php:96:            $ifgroupentry['descr'] = mb_convert_encoding($_POST['descr'],"HTML-ENTITIES","auto");
usr/local/www/interfaces_groups_edit.php:159:           $pconfig['descr'] = mb_convert_encoding($_POST['descr'],"HTML-ENTITIES","auto");
usr/local/www/interfaces_qinq_edit.php:145:             $qinqentry['descr'] = mb_convert_encoding($_POST['descr'],"HTML-ENTITIES","auto");
usr/local/www/interfaces_qinq_edit.php:203:             $pconfig['descr'] = mb_convert_encoding($_POST['descr'],"HTML-ENTITIES","auto");
usr/local/www/services_igmpproxy_edit.php:101:          $igmpentry['descr'] = mb_convert_encoding($_POST['descr'],"HTML-ENTITIES","auto");
usr/local/www/services_igmpproxy_edit.php:117:          $pconfig['descr'] = mb_convert_encoding($_POST['descr'],"HTML-ENTITIES","auto");
Actions #2

Updated by Jim Pingle about 13 years ago

  • Subject changed from Description fields don't accept umlauts to Some description fields don't accept umlauts
Actions #3

Updated by Jim Pingle about 13 years ago

  • Status changed from New to Feedback

Not sure why it didn't associate itself on the ticket, but this should be fixed by the following commit:

https://rcs.pfsense.org/projects/pfsense/repos/mainline/commits/72b7aa4a8ebb397c21f923cc43a2fa6071a907e6

Actions #4

Updated by Jim Pingle about 13 years ago

  • % Done changed from 0 to 100
Actions #5

Updated by Jim Pingle over 11 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF