pfSense

Applied in changeset 1e7eb7900bb3e349c2caadbe9574b1bd774e25a6.

Needed one more fix to make sure the error count was right, but now I think it's doing all it can to ensure errors are captured in a non-fatal way and reported properly.

A couple examples:

: php -f /usr/local/www/status.php
Gathering status data...
Errors: 2
Requested log file is not present: /tmp/PHP_errors.log
Failed to execute command (Firewall-Generated Ruleset Limiters): Command had non-zero exit status: 1
NOTE: Some errors are normal if a feature is not enabled or is inaccessible by the current user.
Saving output to archive...Done.

When run as root on a system that doesn't have IPsec or limiters enabled:

: php -f /usr/local/www/status.php
Gathering status data...
Errors: 9
Failed to execute command (Firewall-Generated Ruleset Limiters): Command had non-zero exit status: 1
Failed to execute command (IPsec-strongSwan Configuration): Command had non-zero exit status: 1
Failed to execute command (IPsec-Configuration): Command had non-zero exit status: 1
Failed to execute command (IPsec-Status-Statistics): Command had non-zero exit status: 64
Failed to execute command (IPsec-Status-Connections): Command had non-zero exit status: 64
Failed to execute command (IPsec-Status-Active SAs): Command had non-zero exit status: 64
Failed to execute command (IPsec-Status-Policies): Command had non-zero exit status: 64
Failed to execute command (IPsec-Status-Certificates): Command had non-zero exit status: 64
Failed to execute command (IPsec-Status-Pools): Command had non-zero exit status: 64
NOTE: Some errors are normal if a feature is not enabled or is inaccessible by the current user.
Saving output to archive...Done.

When run on that same system as a non-root user from the shell:

: php -f /usr/local/www/status.php
Gathering status data...
Errors: 41
Requested log file is not readable: /var/log/system.log
Requested log file is not readable: /var/log/dhcpd.log
Requested log file is not readable: /var/log/filter.log
Requested log file is not readable: /var/log/gateways.log
Requested log file is not readable: /var/log/ipsec.log
Requested log file is not readable: /var/log/l2tps.log
Requested log file is not readable: /var/log/ntpd.log
Requested log file is not readable: /var/log/openvpn.log
Requested log file is not readable: /var/log/portalauth.log
Requested log file is not readable: /var/log/ppp.log
Requested log file is not readable: /var/log/poes.log
Requested log file is not readable: /var/log/resolver.log
Requested log file is not readable: /var/log/routing.log
Requested log file is not readable: /var/log/wireless.log
Failed to execute command (Firewall-Generated Ruleset Limiters): Command had non-zero exit status: 1
Failed to execute command (Firewall-pf NAT Rules): Command had non-zero exit status: 1
Failed to execute command (Firewall-pf Firewall Rules): Command had non-zero exit status: 1
Failed to execute command (Firewall-pf Tables): Command had non-zero exit status: 1
Failed to execute command (Firewall-pf State Table Contents): Command had non-zero exit status: 1
Failed to execute command (Firewall-pf Info): Command had non-zero exit status: 1
Failed to execute command (Firewall-pf Show All): Command had non-zero exit status: 1
Failed to execute command (Firewall-pf Queues): Command had non-zero exit status: 1
Failed to execute command (Firewall-pf OSFP): Command had non-zero exit status: 1
Failed to execute command (Firewall-pftop Default): Command had non-zero exit status: 1
Failed to execute command (Firewall-pftop Long): Command had non-zero exit status: 1
Failed to execute command (Firewall-pftop Queue): Command had non-zero exit status: 1
Failed to execute command (Firewall-pftop Rules): Command had non-zero exit status: 1
Failed to execute command (Firewall-pftop Size): Command had non-zero exit status: 1
Failed to execute command (Firewall-pftop Speed): Command had non-zero exit status: 1
Failed to execute command (Firewall-Limiter Info): Command had non-zero exit status: 69
Failed to execute command (Firewall-Queue Info): Command had non-zero exit status: 69
Failed to execute command (IPsec-strongSwan Configuration): Command had non-zero exit status: 1
Failed to execute command (IPsec-Configuration): Command had non-zero exit status: 1
Failed to execute command (IPsec-Status-Statistics): Command had non-zero exit status: 64
Failed to execute command (IPsec-Status-Connections): Command had non-zero exit status: 64
Failed to execute command (IPsec-Status-Active SAs): Command had non-zero exit status: 64
Failed to execute command (IPsec-Status-Policies): Command had non-zero exit status: 64
Failed to execute command (IPsec-Status-Certificates): Command had non-zero exit status: 64
Failed to execute command (IPsec-Status-Pools): Command had non-zero exit status: 64
Failed to execute command (IPsec-SPD): Command had non-zero exit status: 1
Failed to execute command (IPsec-SAD): Command had non-zero exit status: 1
NOTE: Some errors are normal if a feature is not enabled or is inaccessible by the current user.
Saving output to archive...Done.

Need to wait for a good snapshot build before testing this for sure. The new include file may not have been in this current snapshot but it will be in tomorrow's

Also the current build is missing status_output.inc which will be in the next build.

Working well on the latest snapshot from both the GUI and console, and from root and non-root users. All have the expected output and no PHP errors/crashes.