Bug #1696
Panic when finishing setup wizard with PPPoE WAN
| Status: | Resolved | Start date: | 07/19/2011 | |
|---|---|---|---|---|
| Priority: | High | Due date: | ||
| Assignee: | - | % Done: | 100% |
|
| Category: | Operating System | |||
| Target version: | 2.0 | |||
| Affected version: | 2.0 | Affected Architecture: |
Description
By going through the setup wizard and changing the WAN type to PPPoE, or just changing the PPPoE username and password, after clicking reload at the end of the setup wizard the system will panic as shown in the attached.
Associated revisions
touch up text.
ticket #1696
touch up text.
ticket #1696
Grab a reference during interface pointer handling. This fixes #1696
Fixes #1696. Do not store temporary information under interfaces section during wizards since this might generate a message to netgraph that triggers a panic.
Fixes #1696. Do not store temporary information under interfaces section during wizards since this might generate a message to netgraph that triggers a panic.
If we are coming from a PPPoE/PPTP WAN type, grab the old physical interface first to avoid assigning a ppp interface to itself. Fixes pppoe->pppoe wizard run as well as changing pppoe->dhcp. Fixes #1696
If we are coming from a PPPoE/PPTP WAN type, grab the old physical interface first to avoid assigning a ppp interface to itself. Fixes pppoe->pppoe wizard run as well as changing pppoe->dhcp. Fixes #1696
Another try at prventing panic on reconfig of ppp type wans. Ticket #1696
Another try at prventing panic on reconfig of ppp type wans. Ticket #1696
Revert "Another try at prventing panic on reconfig of ppp type wans. Ticket #1696"
This reverts commit afe88d69235f84530ed6386b22cfc9c488bf94c5.
Revert "Another try at prventing panic on reconfig of ppp type wans. Ticket #1696"
This reverts commit 55a14b686d8f35d03b87efdbddacb656a04f5bed.
History
#1
Updated by Jim P almost 2 years ago
Does this happen on current snapshots? I can't reproduce this in a VM.
#2
Updated by Chris Buechler almost 2 years ago
I can still replicate this. If the WAN is set to PPPoE and you run through the setup wizard leaving the same settings, it panics after reloading at the last step of the wizard.
#3
Updated by Jim P over 1 year ago
I was finally able to reproduce this in a VM, even when the WAN was initially set for DHCP. Same panic message/backtrace.
#4
Updated by Ermal Luçi over 1 year ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset commit:db74464bf6f980c5c5845d53624d4c6f1b139fa7.
#5
Updated by Chris Buechler over 1 year ago
- File pppoepanic2-bt.png added
- Status changed from Feedback to New
no change
#6
Updated by Ermal Luçi over 1 year ago
- Status changed from New to Feedback
Applied in changeset 43d8f1cc9cd5190858ed7220339c0a147cc68dd2.
#7
Updated by Ermal Luçi over 1 year ago
Applied in changeset 851083bd2f9c382dc513d4a10608f5dc840efc01.
#8
Updated by Jim P over 1 year ago
- Status changed from Feedback to New
Panic still happens even after a gitsync picking up these changes. First run through the wizard (going from DHCP to PPPoE) worked for me, second run that was PPPoE to start and ended PPPoE resulted in a crash.
After reboot, doing a single run again (PPPoE to PPPoE) still crashes.
#9
Updated by Jim P over 1 year ago
- Status changed from New to Feedback
Applied in changeset 75bb4bc3849cda6af49ee51cc495353dcb5ad489.
#10
Updated by Jim P over 1 year ago
Applied in changeset 8678130da6c30f82272a1b27b190da3e90211bf1.