Feature #1997

Add date picker to the Custom RRD graph page to translate to unix time.

Added by Seth Mos over 1 year ago. Updated about 1 year ago.

Status:Resolved Start date:11/08/2011
Priority:Low Due date:
Assignee:Darren Embry % Done:

90%
Category:RRD Graphs
Target version:2.1 Estimated time:2.00 hours
Affected version: Affected Architecture:

Description

The current custom rrd graph page needs a startdate and enddate in unix time. This really needs a date picker that sets the unix time to be intuitive and easy to use.

Associated revisions

Revision 59418cee
Added by Darren Embry about 1 year ago

Add date picker to the Custom RRD graph page to translate to unix time.

implements #1997.

http://redmine.pfsense.org/issues/1997

History

#2 Updated by Simon Fong over 1 year ago

That is an EXCELLENT converter, probably the BEST and ONLY one which allows for free-form (eg. 11/9/2011 12:15:59) input of time string, and can also take into account for both UTC and/or GMT timezones. All others requires separate fields for input and only has code for UTC times.

#3 Updated by Chris Buechler about 1 year ago

  • Tracker changed from Bug to Feature
  • Status changed from New to Assigned
  • Assignee set to Darren Embry
  • Affected version deleted (2.1-IPv6)

#4 Updated by Darren Embry about 1 year ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Input fields are now freeform. I went with PHP's strtotime() function for freeform input. It understands time zones and everything.

https://github.com/bsdperimeter/pfsense/commit/59418ceef6ffa89a9da38f4d4a1251dc73d5c05f

#5 Updated by Jim P about 1 year ago

Would still be nice to have a JS Date Picker in the GUI end so people don't have to type it out. Clicking around a calendar is a lot easier. :-)

#6 Updated by Darren Embry about 1 year ago

Okay we have a datepicker now:
https://github.com/bsdperimeter/pfsense/commit/ce49a7c9f2781bda704e4e561026b5e445ab1fcb
Hope the jQuery UI theme I selected matches pfSense closely enough. :-)

#7 Updated by Darren Embry about 1 year ago

  • Status changed from Resolved to Feedback
  • % Done changed from 100 to 90

#8 Updated by Simon Fong about 1 year ago

I hope the date picker will have the ability to accurately "pick" hours, minutes, and seconds rather than rounding to nearest hour/minute or so.

Also I like how some apps on smartphones/tablets allows for BOTH freeform/keyboard AND calendar/GUI picking.

Just curious, during Daylight Savings Time Change, does pfSense's RRD graphs discard or keeps, the added OR subtracted hour of data?

#9 Updated by Darren Embry about 1 year ago

I can't speak for daylight saving time handling but the rest of your needs are fit by this.

http://trentrichardson.com/examples/timepicker/

See that for a demo. It's pretty customizable.

#10 Updated by Chris Buechler about 1 year ago

  • Status changed from Feedback to Resolved

this is fixed, looks good.

Simon - this isn't the place for OT questions, please post to the forum or list.

Also available in: Atom PDF