Project

General

Profile

Actions

Bug #2807

closed

filter_rules_needed tag (in package xml) not used when generating rules

Added by Sander Peterse about 11 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
02/10/2013
Due date:
% Done:

0%

Estimated time:
2.00 h
Plus Target Version:
Affected Version:
All
Affected Plus Version:
Affected Architecture:

Description

The XML tag 'filter_rules_needed' is stored in the $config['installedpackages']['package'][$pkgid]['filter_rule_function'] when a package is being installed:
https://github.com/bsdperimeter/pfsense/blob/master/etc/inc/pkg-utils.inc, function install_package_xml . And is expected to be used when generating firewall rules.

But this value isn't used when generating those rules:
https://github.com/bsdperimeter/pfsense/blob/master/etc/inc/filter.inc, function discover_pkg_rules .

The system looks for a function with the format "{$pkg}_generate_rules". It should use the value from the $config['installedpackages']['package'][$pkgid]['filter_rule_function'] and fallback on the default format of "{$pkg}_generate_rules" when the value isn't defined by the package.

Actions #1

Updated by Ermal Luçi about 11 years ago

  • Status changed from New to Closed

That is a remenant of another implementation for packages.
The only way for now is to use the directly callable function from filter.inc.

Actions

Also available in: Atom PDF