Bug #3001: Captive portal Voucher sync on HTTPS with custom port - pfSense - pfSense bugtracker

Actions

Copy link

Bug #3001

closed

Captive portal Voucher sync on HTTPS with custom port

Added by Zoltan Lukacs almost 11 years ago. Updated almost 11 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Ermal Luçi

Category:

Captive Portal

Target version:

2.1

Start date:

05/21/2013

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

Release Notes:

Affected Version:

2.0.x

Affected Architecture:

All

Description

Voucher sync between 2 pfSense instances using webGUI HTTPS with custom port (Ex. 33333) is not working.

An error code was received while attempting CaptivePortalVoucherSync XMLRPC sync with http://192.168.67.16:33333 - Code 2: Invalid return payload: enable debugging to examine incoming payload

On the below code snippet you can see that HTTPS will be used only when port == 443.

https://github.com/pfsense/pfsense/blob/master/usr/local/www/services_captiveportal_vouchers.php

if($newvoucher['vouchersyncport'] == "443") 
    $url = "https://{$newvoucher['vouchersyncdbip']}";
else 
    $url = "http://{$newvoucher['vouchersyncdbip']}";

I would like to fix this, but I'm not a PHP coder... :(
Suggestion: Ability to select protocol on webGUI beside custom port.

Files

Download all files

Captive_Portal_Voucher_Sync_Over_Non_standard_HTTPS_Port.png (56.2 KB) Captive_Portal_Voucher_Sync_Over_Non_standard_HTTPS_Port.png		Josh Cavalier, 07/02/2013 09:24 PM
Captive_Portal_Voucher_Packet_Capture.png (94.3 KB) Captive_Portal_Voucher_Packet_Capture.png		Josh Cavalier, 07/02/2013 09:24 PM
Captive_Portal_Log.PNG (36.2 KB) Captive_Portal_Log.PNG		Josh Cavalier, 07/02/2013 09:27 PM

Actions

Copy link

Updated by Ermal Luçi almost 11 years ago

Status changed from New to Feedback
% Done changed from 0 to 100

Applied in changeset f9d480ff0b4a0cbd569a600ba6087770226ddba5.

Actions

Copy link

Updated by Ermal Luçi almost 11 years ago

Applied in changeset 368d34c31aed69fe5f0c44814367a2658f4b4bc0.

Actions

Copy link

Updated by Josh Cavalier almost 11 years ago

Ok, I have tested this and it works properly. I've setup two VM's with three interfaces each. WAN (192.168.17.0/24), LAN (host only network (10.10.10.0/24)) and OPT1 (host only interface). I then changed the HTTPS port to 33333 on both machines (as above example) and configured captive portal on host 1 - OPT1. I also created vouchers on host1 (screenshot). I then configured captive portal on host2 - OPT1, enabled vouchers and entered host1's LAN details in the Voucher database synchronization including port 33333. Running a packet capture on host1 shows the SSL stream over port 33333, and the screenshot shows vouchers synced properly. I have tested this twice.

Actions

Copy link