Project

General

Profile

Actions
Copy link

Bug #5088

closed

system_authservers.php - When input validation errors occur, several field values are lost

Added by Jim Pingle over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Target version:
pfSense - 2.3
Start date:
09/03/2015
Due date:
% Done:

100%

Estimated time:
Spent time:
1.50 h

Description

When you save an auth server, LDAP for example, and an input validation problem happens, several fields are lost. Might be more than this but this is what I noticed:

  • Authentication containers is blank
  • User/group/member attributes reset
Actions
Copy link
 #1

Updated by Anonymous over 8 years ago

  • Status changed from Confirmed to Feedback
  • Assignee changed from Anonymous to Jim Pingle

Functionality was not present in 2.2. Added $pconfig = $_POST to restore form contents on validation failure

Actions
Copy link
 #2

Updated by Anonymous over 8 years ago

  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Jim Pingle over 8 years ago

  • Status changed from Feedback to Confirmed
  • Assignee changed from Jim Pingle to Anonymous

Behavior seems to be the same. Some fields like "Base DN" stay, but the ones mentioned in the original description disappear (e.g. Authentication Containers)

For testing, here are the fields and what I entered. To reproduce the input error, simply make a second entry with an identical name:

Descriptive Name: OpenLDAPTest
Type: LDAP
Hostname or IP address: 192.168.1.2
Port value: 389
Transport: TCP - Standard
Protocol Version: 3
Search Scope:
Level: Entire Subtree
Base DN: dc=pfsense,dc=org
Authentication Containers: ou=people,dc=pfsense,dc=org;ou=groups,dc=pfsense,dc=org
Extended Query: Checked, memberOf=cn=foo (not really valid but doesn't need to be)
Bind anonymous: Checked
Initial Template: OpenLDAP
User naming attribute: cn
Group naming attribute: cn
Group member attribute: memberUid
UTF8: Checked
Username Alterations: Unchecked

Actions
Copy link
 #4

Updated by Anonymous over 8 years ago

  • Status changed from Confirmed to Feedback
Actions
Copy link
 #5

Updated by Anonymous over 8 years ago

  • Assignee changed from Anonymous to Jim Pingle

I had been testing by omitting the IP address and so causing an error. Unfortunately that takes a slightly different code path than the duplicate entry error.

Now corrected.

Actions
Copy link
 #6

Updated by Jim Pingle over 8 years ago

  • Status changed from Feedback to Resolved

Works correctly now, thanks!

Actions
Copy link

Also available in: Atom PDF