Project

General

Profile

Bug #6227

LAGG MTU not set correctly when it has child QinQ interfaces

Added by Chris Rowe 10 months ago. Updated 10 days ago.

Status:
Resolved
Priority:
Normal
Category:
Interfaces
Target version:
Start date:
04/21/2016
Due date:
% Done:

0%

Affected version:
2.3.x
Affected Architecture:

Description

Issue number 2786 (https://redmine.pfsense.org/issues/2786) describes an issue where the MTU on the parent interfaces of a LAGG or VLAN were not being set correctly. This was resolved for the most part, but the solution didn't apply correctly for an instance where you have a QinQ on top of a LAGG. The MTU of the QinQ interfaces is not being read and hence the MTU of the parent interfaces and LAGG as a whole default to 1500.

I've managed to use the changes made in that bug to, for the most part, resolve this. Apologies, I'm not a programmer and don't have a clue how to create a diff or pull request. So for the moment will just upload the entire interface.inc that I have modified.

The changes I've made will check for any child QinQs on a LAGG, check their MTU values and set the LAGG MTU accordingly. Ideally, this would be modified slightly, so that if there are Child QinQs and no MTU has been explicitly set on them, the LAGG is set to 1504 to allow for the additional header overhead of the QinQ. I might take a look at doing this later.

interfaces.inc (172 KB) Chris Rowe, 04/21/2016 02:01 PM

interfaces.inc.diff Magnifier (1.92 KB) Chris Rowe, 04/22/2016 03:16 AM

History

#1 Updated by Chris Rowe 10 months ago

Figured out how to make a diff file of the changes, attached.

#2 Updated by Chris Rowe 10 months ago

#3 Updated by Luiz Otavio O Souza 9 months ago

  • Assignee set to Luiz Otavio O Souza

#4 Updated by Chris Buechler 9 months ago

  • Status changed from New to Confirmed
  • Target version set to 2.3.2
  • Affected version changed from 2.3 to 2.3.x

that PR seems fine to merge. Luiz, please review and merge if agreed.

#5 Updated by Chris Buechler 8 months ago

  • Target version changed from 2.3.2 to 2.4.0

#6 Updated by Chris Buechler 7 months ago

  • Status changed from Confirmed to Feedback

PR merged

#7 Updated by Jim Pingle 10 days ago

  • Status changed from Feedback to Resolved
  • Target version changed from 2.4.0 to 2.3.3

Also available in: Atom PDF