Project

General

Profile

Bug #6997

DHCP/DHCPv6 server GUI should be accessible even if DHCP relay is enabled

Added by Kill Bill 2 months ago. Updated 10 days ago.

Status:
Resolved
Priority:
Low
Category:
Web Interface
Target version:
Start date:
12/09/2016
Due date:
% Done:

100%

Affected version:
All
Affected Architecture:
All

Description

So, I wanted to copy the DHCP static leases from the GUI. Cannot do, since all I get is "DHCP Relay is currently enabled. Cannot enable the DHCP Server service while the DHCP Relay is enabled on any interface." It would be a whole lot better if the GUI disabled the "Enable DHCP server on $foo interface" checkbox, instead of making the GUI inaccessible.

Besides, if someone wants to configure static ARP (which works even with the DHCP server being disabled), this is the only GUI where they can do so.

History

#1 Updated by Phillip Davis 2 months ago

This looks not too hard to do, and will help those who would like to be able to see and manipulate disabled-DHCP-server settings, static mappings... while they are running DHCP Relay at the same time.

As a side-issue while looking at how server and relay interact I got annoyed with some of the way that the DHCP Relay UI functioned, and that is fixed up by https://github.com/pfsense/pfsense/commit/ac999f3b7894bd8d5fc35419a22cc2df39416e42

I am looking at the code - someone can assign me if they like.

#2 Updated by Kill Bill 2 months ago

Thanks, Phil. And yes, also when migrating the other way round (i.e., when moving your DHCP to pfSense), you want to have everything set up in advance, to minimize downtime.

#3 Updated by Kill Bill 2 months ago

One more thing I noticed - Status/DHCP Leases, on the contrary, is something that should not be accessible when DHCP server is disabled, since the data there make no sense in that case.

#4 Updated by Phillip Davis 2 months ago

https://github.com/pfsense/pfsense/pull/3271 addresses the DHCP (v4) Server part.

#5 Updated by Phillip Davis 2 months ago

Some fixups/enhancements to Status DHCP Leases in https://github.com/pfsense/pfsense/pull/3273
If DHCP Server is disabled, then Status DHCP Leases still shows the static mappings. That provides a place to see a table of all the static mappings, so maybe it is still useful? Or maybe it should say something about the DHCP Server being disabled so that the user is aware of that when viewing the status display?

#6 Updated by Kill Bill 2 months ago

Phillip Davis wrote:

Some fixups/enhancements to Status DHCP Leases in https://github.com/pfsense/pfsense/pull/3273
If DHCP Server is disabled, then Status DHCP Leases still shows the static mappings. That provides a place to see a table of all the static mappings, so maybe it is still useful?

Well yes, possibly the static ones (however, you can still see the same data in the DHCP Server GUI.) The rest (non-static) is just completely misleading noise and potentially years old irrelevant data. Perhaps just filter out everything but static leases from there when DHCP server is disabled?

While messing with this - perhaps a button to nuke the entire /var/dhcpd/var/db/{dhcpd,dhcpd6}.leases file would be useful to have somewhere in the GUI, cannot see any good way to mass nuke the leases via the GUI.

#7 Updated by Phillip Davis 2 months ago

https://github.com/pfsense/pfsense/pull/3274 addresses the DHCP (v6) Server part.

#8 Updated by Renato Botelho 2 months ago

  • Assignee set to Renato Botelho
  • Target version set to 2.4.0

#9 Updated by Renato Botelho 2 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Both PRs merged, thanks!

#10 Updated by Kill Bill 2 months ago

Works, thanks! 8-)

#11 Updated by Renato Botelho 2 months ago

  • Status changed from Feedback to Resolved

#12 Updated by Jim Pingle 10 days ago

  • Target version changed from 2.4.0 to 2.3.3

Also available in: Atom PDF