Project

General

Profile

Bug #7164

NTP page allows adding more time server rows than it saves to the configuration

Added by Jack Booth about 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Category:
NTPD
Target version:
Start date:
01/25/2017
Due date:
% Done:

100%

Affected version:
2.3.x
Affected Architecture:

Description

The NTP configuration page has a button to add more time servers to use as a time source. Only 10 servers are saved to the configuration but the page allows you to add as many rows as you like, storing only the first 10. This should be changed to only allow the creation fields for as many time sources as will actually be saved to the config.

Associated revisions

Revision 5a1d67b1
Added by Jack Booth about 2 months ago

Bug #7164 Limit NTP time source fields to the maximum number saved to configuration.

Revision 7533bdcf
Added by Jack Booth about 2 months ago

Bug #7164 Limit NTP time source fields to the maximum number saved to configuration.

(cherry picked from commit 5a1d67b17d485697e19ef49d66e8e5f91e7e884d)

History

#2 Updated by Steve Beaver about 2 months ago

Why is the page limited to 10 servers? Is this limitation enforced elsewhere in the system?

#3 Updated by Jack Booth about 2 months ago

I can't answer the question of why other than it is generally not recommended to specify a large number of time servers. The limit is simply within the page and ntp would allow more if the page saved more to the configuration. Why the limit was chosen as 10 in the past I do not know. But I consider that to be a separate request. I just think if there is a limit the page should actually use it.

#4 Updated by Kill Bill about 2 months ago

Most likely limited to 10 because historically anything above 10 best servers was discarded as a potential peer [1]. May not be applicable any more but cannot see the point here configuring inordinate amount of NTP servers, basically abuse of free service.

[1] http://lists.ntp.org/pipermail/questions/2007-October/015895.html

#5 Updated by Renato Botelho about 2 months ago

  • Category set to NTPD
  • Status changed from New to Feedback
  • Assignee changed from Jack Booth to Renato Botelho
  • Target version set to 2.4.0
  • % Done changed from 0 to 100

PR has been merged, thanks!

#6 Updated by James Snell about 2 months ago

Build 2.4.0.b.20170207.2344

Test:

  • Under Services -> NTP
  • Attempt to add 11 server addresses

Result: Error message popup after 10 servers entered.

TEST PASSED

Thanks!

#7 Updated by Jim Pingle about 1 month ago

  • Target version changed from 2.4.0 to 2.3.3
  • Affected version set to 2.3.x

#8 Updated by Renato Botelho about 1 month ago

  • Status changed from Feedback to Resolved

works

Also available in: Atom PDF