Bug #7164
closed
NTP page allows adding more time server rows than it saves to the configuration
100%
Description
The NTP configuration page has a button to add more time servers to use as a time source. Only 10 servers are saved to the configuration but the page allows you to add as many rows as you like, storing only the first 10. This should be changed to only allow the creation fields for as many time sources as will actually be saved to the config.
Updated by Jack Booth about 7 years ago
Updated by Anonymous about 7 years ago
Why is the page limited to 10 servers? Is this limitation enforced elsewhere in the system?
Updated by Jack Booth about 7 years ago
I can't answer the question of why other than it is generally not recommended to specify a large number of time servers. The limit is simply within the page and ntp would allow more if the page saved more to the configuration. Why the limit was chosen as 10 in the past I do not know. But I consider that to be a separate request. I just think if there is a limit the page should actually use it.
Updated by Kill Bill about 7 years ago
Most likely limited to 10 because historically anything above 10 best servers was discarded as a potential peer [1]. May not be applicable any more but cannot see the point here configuring inordinate amount of NTP servers, basically abuse of free service.
[1] http://lists.ntp.org/pipermail/questions/2007-October/015895.html
Updated by Renato Botelho about 7 years ago
- Category set to NTPD
- Status changed from New to Feedback
- Assignee changed from Jack Booth to Renato Botelho
- Target version set to 2.4.0
- % Done changed from 0 to 100
PR has been merged, thanks!
Updated by James Snell about 7 years ago
Build 2.4.0.b.20170207.2344
Test:
- Under Services -> NTP
- Attempt to add 11 server addresses
Result: Error message popup after 10 servers entered.
TEST PASSED
Thanks!
Updated by Jim Pingle about 7 years ago
- Target version changed from 2.4.0 to 2.3.3
- Affected Version set to 2.3.x