Project

General

Profile

Bug #10183

diag_packet_capture.php: Capture for 'pfsync' fails

Added by Jim Pingle about 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Packet Capture
Target version:
Start date:
01/13/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
All

Description

On diag_packet_capture.php, attempting to capture traffic fails when the protocol is set to 'pfsync'.

This happens on 2.4.5 and 2.5.0, with an error similar to:

Warning: filesize(): stat failed for /root/packetcapture.cap in /usr/local/www/diag_packet_capture.php on line 537

It appears to fail silently on 2.4.4-p3 as well. The command it forms yields a syntax error when attempted directly at the command line.

Looks like it needs a protocol fixup similar to ospf/carp.

To me, I'm working on a fix.

Associated revisions

Revision 1d2dbda2 (diff)
Added by Jim Pingle about 2 months ago

Use correct pfsync packet capture syntax. Fixes #10183

Revision 3f571682 (diff)
Added by Jim Pingle about 2 months ago

Sync diag_packet_capture.php with master

  • Adds multiple TCP/UDP port input. Issue #9766
  • Adds packet capture start time info. Issue #9831
  • Adds OSPF protocol capture. Issue #9905
  • Corrects pfsync capture syntax. Fixes #10183

Revision 27f52f53 (diff)
Added by Jim Pingle about 2 months ago

diag_packet_capture.php: Input and error checks. Fixes #10183

  • Prevent selecting Address Family and ARP, it is not a valid
    combination.
  • Prevent PHP errors when the capture file is missing unexpectedly
  • Add collapsed info box with running command for debug/curious users.

Revision 07060399 (diff)
Added by Jim Pingle about 2 months ago

diag_packet_capture.php: Input and error checks. Fixes #10183

  • Prevent selecting Address Family and ARP, it is not a valid
    combination.
  • Prevent PHP errors when the capture file is missing unexpectedly
  • Add collapsed info box with running command for debug/curious users.

(cherry picked from commit 27f52f5385a46f3896b08a7a90258be43fadb8de)

History

#1 Updated by Jim Pingle about 2 months ago

  • Status changed from Confirmed to In Progress

#2 Updated by Jim Pingle about 2 months ago

  • Category changed from Diagnostics to Packet Capture

#3 Updated by Jim Pingle about 2 months ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100

#4 Updated by Raul Ramos about 2 months ago

With the combination Address family: IPv4 and ARP protocol i have the same warning

#5 Updated by Jim Pingle about 2 months ago

  • Status changed from Feedback to In Progress

#6 Updated by Jim Pingle about 2 months ago

  • Status changed from In Progress to Feedback

#7 Updated by Jim Pingle about 1 month ago

  • Status changed from Feedback to Resolved

Works fine on 2.4.5.a.20200114.0923

Also available in: Atom PDF