Project

General

Profile

Bug #10275

L2TP and PPPoE user password issues

Added by Jim Pingle about 1 month ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
L2TP
Target version:
Start date:
02/21/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
All

Description

When defining local users in L2TP and PPPoE, there are two issues with passwords:

1. Passwords should not be allowed to start with "!" which has special meaning to mpd (defines an external auth command, not a password)
2. Double quotes (") in passwords should be escaped as \" or it will break the user definition

Associated revisions

Revision 48dae98c (diff)
Added by Jim Pingle about 1 month ago

L2TP and PPPoE user password validation. Fixes #10275

Revision e6ea77eb (diff)
Added by Jim Pingle about 1 month ago

L2TP and PPPoE user password validation. Fixes #10275

(cherry picked from commit 48dae98cf7837af3071521bdabb788af6d3e0f41)

History

#1 Updated by Jim Pingle about 1 month ago

  • Target version set to 2.4.5

#2 Updated by Jim Pingle about 1 month ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Viktor Gurov about 1 month ago

  • Status changed from Feedback to Resolved

tested on 2.4.5.r.20200221.2100

Passwords started with "!" - ok, WebGUI error message
Double quotes (") in passwords - ok, see

testuser "\"testpass\""
in /var/etc/l2tp-vpn/mpd.secret

Also available in: Atom PDF