Project

General

Profile

Bug #10405

Additional instances of ACME Domain SAN list entries with passwords are rendered as checkboxes

Added by Jim Pingle 2 months ago. Updated 2 months ago.

Status:
Feedback
Priority:
High
Assignee:
Category:
ACME
Target version:
-
Start date:
04/01/2020
Due date:
% Done:

0%

Estimated time:
Affected Version:
Affected Architecture:

Description

When adding more than one Domain SAN list entry to an ACME certificate, password type fields are rendered as checkboxes.

The JS function that creates the fields is apparently missing a case for password inputs.

Somewhat easy fix:

diff --git a/security/pfSense-pkg-acme/files/usr/local/pkg/acme/acme_htmllist.inc b/security/pfSense-pkg-acme/files/usr/local/pkg/acme/acme_htmllist.inc
index dc8503a0493b..2a70edd8aab5 100644
--- a/security/pfSense-pkg-acme/files/usr/local/pkg/acme/acme_htmllist.inc
+++ b/security/pfSense-pkg-acme/files/usr/local/pkg/acme/acme_htmllist.inc
@@ -402,6 +402,10 @@ function acme_htmllist_js($tablename = "") {
                        result="<input name='" + tableId + field['name'] + rowId +
                        "' id='" + tableId + field['name'] + rowId +
                        "'><\/input> ";
+               } else if(field['type'] === 'password') {
+                       result="<input name='" + tableId + field['name'] + rowId +
+                       "' id='" + tableId + field['name'] + rowId +
+                       "' type='password'\/> ";
                } else if(field['type'] === 'textarea') {
                        result="<textarea class='form-control nowrap' cols='" + field['size'] + "' rows='15' style='width:100%' name='" + tableId + field['name'] + rowId +
                        "' id='" + tableId + field['name'] + rowId +

History

#1 Updated by Jim Pingle 2 months ago

  • Status changed from New to Feedback

This is fixed in ACME package version 0.6.6

Also available in: Atom PDF