https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162020-06-12T18:51:21ZpfSense bugtrackerpfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=467512020-06-12T18:51:21ZVincent Jansen
<ul></ul><p>% on opt1 was issue. Using mbps fixed it.</p> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=467522020-06-12T18:53:32ZVincent Jansen
<ul></ul><p>2.4.5-p1</p> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=467582020-06-13T11:37:42ZViktor Gurov
<ul><li><strong>Category</strong> set to <i>Traffic Shaper (ALTQ)</i></li><li><strong>Affected Version</strong> set to <i>2.4.5-p1</i></li></ul><p>Fix:<br /><a class="external" href="https://github.com/pfsense/pfsense/pull/4355">https://github.com/pfsense/pfsense/pull/4355</a></p> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=467592020-06-13T11:53:21ZViktor Gurov
<ul></ul><p>Vincent Jansen wrote:</p>
<blockquote>
<p>2.4.5-p1</p>
</blockquote>
<p>What is your interface?<br />I got the same issue with <em>vtnet</em> interface</p>
<p>This may be another issue, pf.conf(5):</p>
<p>bandwidth</p>
<pre><code>The maximum bitrate for all queues on an interface may be specified<br /> using the bandwidth keyword. The value can be specified as an ab-<br /> solute value or as a percentage of the interface bandwidth. When<br /> using an absolute value, the suffixes b, Kb, Mb, and Gb are used to<br /> represent bits, kilobits, megabits, and gigabits per second, re-<br /> spectively. The value must not exceed the interface bandwidth. If<br /> bandwidth is not specified, the interface bandwidth is used (<strong>but<br /> take note that some interfaces do not know their bandwidth</strong>, or can<br /> adapt their bandwidth rates).</code></pre> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=467602020-06-13T12:16:37ZVincent Jansen
<ul></ul><p>Opt1 = openvpn</p> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=467732020-06-15T08:22:04ZJim Pingle
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Low</i></li></ul><p>That is most likely because, as Viktor noted, you tried to use % bandwidth on an interface that can't properly identify its own line rate so it cannot calculate a percentage.</p>
<p>The code could maybe be smarter about trying to identify that situation and warn about it when configuring in the GUI, and also before crafting % rules. Someone could pick % rules on a valid interface and then reassign interfaces to something invalid, so the backend needs to be smart about checking before loading the shaper config. If it is invalid at run-time the entire shaper config would need to be tossed out.</p> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=467802020-06-15T09:20:12ZVincent Jansen
<ul></ul><p>I'd at least expected the UI to load instead of just showing an full-screen error and forcing me to revert using backing & restore.<br />A normal user can't be confronted with a broken UI after putting UI-allowed stuff in fields and click save.</p> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=468022020-06-17T07:13:17ZViktor Gurov
<ul></ul><p>Jim Pingle wrote:</p>
<blockquote>
<p>That is most likely because, as Viktor noted, you tried to use % bandwidth on an interface that can't properly identify its own line rate so it cannot calculate a percentage.</p>
</blockquote>
<p>I think this should be another issue</p>
<p>class 'altq_root_queue' has no method 'GetParent()',<br />this PR adds check:<br /><a class="external" href="https://github.com/pfsense/pfsense/pull/4358">https://github.com/pfsense/pfsense/pull/4358</a></p> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=468032020-06-17T08:15:01ZViktor Gurov
<ul></ul><p>another error after applying PR:<br /><pre>
`There were error(s) loading the rules: pfctl: interface vtnet2 bandwidth limited to 4294967295 bps because selected
scheduler is 32-bit limited - The line in question reads [0]: @ 2020-06-17 16:08:25`
</pre></p>
<p>need a way to check that interface can properly identify its own line rate</p> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=469292020-06-24T09:29:11ZRenato Botelhorenato@netgate.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>Assignee</strong> set to <i>Renato Botelho</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>PR has been merged. Thanks!</p> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=492482020-11-05T22:15:44ZMax Leighton
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>Tested patch in 2.4.5p1 and in 2.5.0-DEVELOPMENT built on Thu Nov 05 19:03:52 EST 2020</p>
<p>Seems to be working as expected. I can't recreate the error anymore after applying the patch. Marking the ticket resolved.</p> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=492522020-11-06T07:08:50ZJim Pingle
<ul><li><strong>Target version</strong> set to <i>2.5.0</i></li></ul> pfSense - Bug #10660: PHP errors in the traffic shaper wizardhttps://redmine.pfsense.org/issues/10660?journal_id=493592020-11-10T13:38:59ZJim Pingle
<ul><li><strong>Subject</strong> changed from <i>Bug firewall_shaper.php</i> to <i>PHP errors in the traffic shaper wizard</i></li></ul>