https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162020-07-29T08:40:10ZpfSense bugtrackerpfSense - Bug #10798: Unable to save CP zone named 'VIP'https://redmine.pfsense.org/issues/10798?journal_id=473422020-07-29T08:40:10ZViktor Gurov
<ul></ul><p>config.xml after creating 'VIP' zone:<br /><pre>
<captiveportal>
<vip>VIP</vip>
<vip></vip>
<vip></vip>
<vip>2</vip>
<vip>lan</vip>
<vip>test</vip>
<vip></vip>
<vip></vip>
<vip></vip>
<vip></vip>
<vip></vip>
<vip></vip>
<vip></vip>
<vip>authserver</vip>
<vip>ldap - Serv1LDAP</vip>
<vip></vip>
<vip>LocalRADIUS</vip>
<vip></vip>
<vip></vip>
<vip></vip>
<vip></vip>
<vip>5efaed056f950</vip>
<vip></vip>
<vip>default</vip>
<vip></vip>
<vip></vip>
<vip></vip>
</captiveportal>
</pre></p> pfSense - Bug #10798: Unable to save CP zone named 'VIP'https://redmine.pfsense.org/issues/10798?journal_id=473482020-07-29T08:49:46ZJim Pingle
<ul><li><strong>Target version</strong> set to <i>2.5.0</i></li></ul><p>It's because the zone name is used as an XML tag in the config, but "vip" is a listtag, meaning it gets treated like an array. We should add input validation to prevent any list tags from being accepted as zone names.</p>
<p>See <a class="source" href="https://redmine.pfsense.org/projects/pfsense/repository/2/entry/src/etc/inc/xmlparse.inc#L29">source:src/etc/inc/xmlparse.inc#L29</a> -- <code>listtags()</code> and <code>listtags_pkg()</code></p> pfSense - Bug #10798: Unable to save CP zone named 'VIP'https://redmine.pfsense.org/issues/10798?journal_id=473492020-07-29T09:59:13ZViktor Gurov
<ul></ul><p><a class="external" href="https://github.com/pfsense/pfsense/pull/4410">https://github.com/pfsense/pfsense/pull/4410</a></p> pfSense - Bug #10798: Unable to save CP zone named 'VIP'https://redmine.pfsense.org/issues/10798?journal_id=473502020-07-29T10:10:52ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Pull Request Review</i></li></ul> pfSense - Bug #10798: Unable to save CP zone named 'VIP'https://redmine.pfsense.org/issues/10798?journal_id=474942020-08-18T18:07:26ZRenato Botelhorenato@netgate.com
<ul><li><strong>Status</strong> changed from <i>Pull Request Review</i> to <i>Feedback</i></li><li><strong>Assignee</strong> set to <i>Renato Botelho</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>PR has been merged. Thanks!</p> pfSense - Bug #10798: Unable to save CP zone named 'VIP'https://redmine.pfsense.org/issues/10798?journal_id=475542020-08-24T13:11:02ZDanilo Zrenjanin
<ul><li><strong>File</strong> <a href="/attachments/3140">Services_ Captive Portal_ Add Zone 2020-08-24 20-09-12.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3140/Services_%20Captive%20Portal_%20Add%20Zone%202020-08-24%2020-09-12.png">Services_ Captive Portal_ Add Zone 2020-08-24 20-09-12.png</a> added</li><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>Tested on:<br />2.5.0-DEVELOPMENT (amd64)<br />built on Mon Aug 24 07:02:12 EDT 2020<br />FreeBSD 12.1-STABLE</p>
<p>I was not able to add the zone named vip, tunnel, user, or any other name from the listtags listing.</p>
<p>I am resolving the ticket.</p>