Project

General

Profile

Bug #10889

Hover text missing from Static Routes Page

Added by Kris Phillips about 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Category:
Web Interface
Target version:
Start date:
09/11/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.5-p1
Affected Architecture:
All

Description

The enabled/disabled checkmarks are missing mouse-over help text for the "Enabled/Disabled" icons on system_routes.php similar to bug report https://redmine.pfsense.org/issues/10719 for the system_gateways.php. This should probably be included in both since we have patched in tooltips on the gateways page.

Associated revisions

Revision 6639718c (diff)
Added by Viktor Gurov about 2 months ago

Static Routes Page tooltips and help text. Fixes #10889

History

#1 Updated by Viktor Gurov about 2 months ago

  • Target version set to 2.5.0
  • Affected Version set to 2.4.5-p1

#2 Updated by Jim Pingle about 2 months ago

  • Status changed from New to Pull Request Review

#3 Updated by Renato Botelho about 1 month ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#4 Updated by Kris Phillips about 1 month ago

Renato Botelho wrote:

PR has been merged. Thanks!

Hello Renato,

Do you have a System Patch for applying this to 2.4.5p1 or will it require waiting for a new build of 2.5 to test?

#5 Updated by Renato Botelho about 1 month ago

Kris Phillips wrote:

Renato Botelho wrote:

PR has been merged. Thanks!

Hello Renato,

Do you have a System Patch for applying this to 2.4.5p1 or will it require waiting for a new build of 2.5 to test?

You can try to apply https://patch-diff.githubusercontent.com/raw/pfsense/pfsense/pull/4438.diff but I'm not sure if it applies cleanly or not. This change is targeted to be part of 2.5.0

#6 Updated by Max Leighton about 1 month ago

  • Status changed from Feedback to Resolved

Tested in

2.5.0-DEVELOPMENT (amd64)
built on Sun Sep 27 13:02:36 EDT 2020
FreeBSD 12.2-PRERELEASE

Mouseover text for gateway enabled/disabled as well as default gateway mouseover text now appears. The patch won't apply cleanly in 2.4.5_p1 so this needs to be done in 2.5.

Marking the ticket resolved.

Also available in: Atom PDF