Project

General

Profile

Bug #11382

OpenVPN client configuration page displays Shared Key option when set for SSL/TLS

Added by Viktor Gurov 2 months ago. Updated 23 days ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
OpenVPN
Target version:
Start date:
02/08/2021
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.5-p1
Affected Architecture:
Release Notes:
Default

Description

If you create an OpenVPN client instance in the 'Shared Key' mode and then switch it to "SSL/TLS" mode, the WebGUI still shows the 'Shared Key' field

Associated revisions

Revision f22b2155 (diff)
Added by Viktor Gurov about 2 months ago

Hide Shared Key field on OpenVPN client page in SSL/TLS mode. Fixes #11382

Revision 2c4ce8b1 (diff)
Added by Viktor Gurov about 1 month ago

Hide Shared Key field on OpenVPN client page in SSL/TLS mode. Fixes #11382

(cherry picked from commit f22b21557e6a745dbb447ea488b97424e595efd7)

History

#1 Updated by Viktor Gurov 2 months ago

it also hides the `tlsauth_keydir` field for 'Shared Key" mode (see #11336):
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/126

#2 Updated by Renato Botelho 2 months ago

  • Status changed from New to Pull Request Review
  • Assignee set to Viktor Gurov
  • Target version set to CE-Next

#3 Updated by Renato Botelho about 2 months ago

  • Status changed from Pull Request Review to Feedback

PR has been merged. Thanks!

#4 Updated by Viktor Gurov about 2 months ago

  • % Done changed from 0 to 100

#5 Updated by Jim Pingle about 1 month ago

  • Status changed from Feedback to Waiting on Merge
  • Target version changed from CE-Next to 2.5.1

#6 Updated by Renato Botelho about 1 month ago

  • Status changed from Waiting on Merge to Feedback

Cherry-picked to RELENG_2_5_1

#7 Updated by Jim Pingle about 1 month ago

  • Subject changed from OpenVPN client page shows 'Shared Key' in SSL/TLS mode to OpenVPN client configuration page displays Shared Key option when set for SSL/TLS

Updating subject for release notes.

#8 Updated by Alhusein Zawi 23 days ago

Tested on 21.02.2.r.20210325.0300

Shared Key option is not displayed when Server mode is for SSL/TLS in client configuration page. (Fixed)

Note: in Server configuration page if I unchecked Automatically generate a shared key then added it manually and Saved , Automatically generate a shared key option will be disappeared then I will not be able to choose it again.

#9 Updated by Viktor Gurov 23 days ago

  • Status changed from Feedback to Resolved

Alhusein Zawi wrote:

Tested on 21.02.2.r.20210325.0300

Shared Key option is not displayed when Server mode is for SSL/TLS in client configuration page. (Fixed)

Note: in Server configuration page if I unchecked Automatically generate a shared key then added it manually and Saved , Automatically generate a shared key option will be disappeared then I will not be able to choose it again.

This is the correct behavior

Also available in: Atom PDF