Project

General

Profile

Actions
Copy link

Bug #11456

closed
B. VG

Unbound Python Integration repeatedly mounts ``dev`` without unmounting

Bug #11456: Unbound Python Integration repeatedly mounts ``dev`` without unmounting

Added by BBcan177 . over 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Viktor Gurov
Category:
DNS Resolver
Target version:
2.5.2
Start date:
02/18/2021
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
21.05
Release Notes:
Default
Affected Version:
All
Affected Architecture:

Description

As reported here:
https://www.reddit.com/r/pfBlockerNG/comments/ln1gx1/pfblockerngdevel_leaking_mounts/

In file: /etc/inc/services.inc
Function: services_unbound_configure()
Line# 2430

Reference:
https://github.com/pfsense/pfsense/blob/master/src/etc/inc/services.inc#L2430

Each time Unbound is restarted from pfSense, it will add a new Mount for devfs. This needs to be validated first to see if it has already been mounted, and not add additional mounts if it already exists.

A similar validation exists in function services_dhcp_configure()

Reference:
https://github.com/pfsense/pfsense/blob/master/src/etc/inc/services.inc#L450-L452

The original commit here:
https://github.com/pfsense/pfsense/commit/d83d2280d4e104793840c97a1e33e688067c9f1c#diff-bfa3d43ab33dd4467f6d92f7329db45a738563d38215c4c31703f9c7e18e3f3d

Original Redmine:
#9251

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #2

  • Status changed from New to Pull Request Review
  • Target version set to CE-Next

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #3

  • Plus Target Version set to 21.05

Updated by Anonymous over 5 years ago Actions
Copy link
 #4

  • Status changed from Pull Request Review to Feedback

VG Updated by Viktor Gurov over 5 years ago Actions
Copy link
 #5

  • % Done changed from 0 to 100

Applied in changeset commit:a72b320ee3d7d29563210e62b132afd0d76f1165.

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #6

  • Subject changed from pfSense Unbound Python Integration - Dev mount to pfSense Unbound Python Integration repeatedly mounts ``dev`` without unmounting

Updating subject for release notes.

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #7

  • Subject changed from pfSense Unbound Python Integration repeatedly mounts ``dev`` without unmounting to Unbound Python Integration repeatedly mounts ``dev`` without unmounting

Updating subject for release notes.

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #8

  • Target version changed from CE-Next to 2.5.2

VG Updated by Viktor Gurov over 5 years ago Actions
Copy link
 #9

  • Status changed from Feedback to Resolved

works as expected on 2.5.2.b.20210602.0300 -
I only see one mount point after multiple restarts of pfBlockerNG(Python mode):

# mount | grep /var/unbound/dev
devfs on /var/unbound/dev (devfs, local)

same on 2.5.1:

# mount | grep /var/unbound/dev
devfs on /var/unbound/dev (devfs, local)
devfs on /var/unbound/dev (devfs, local)

RB Updated by Renato Botelho about 5 years ago Actions
Copy link
 #10

  • Assignee set to Viktor Gurov
Actions
Copy link

Also available in: Atom