https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162021-11-05T22:06:33ZpfSense bugtrackerpfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573352021-11-05T22:06:33ZChristian Borchertccb056@gmail.com
<ul></ul><p>Bounty here: <a class="external" href="https://forum.netgate.com/topic/167670/ntp-add-peer-100">https://forum.netgate.com/topic/167670/ntp-add-peer-100</a></p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573682021-11-12T01:55:52ZViktor Gurov
<ul></ul><p><a class="external" href="https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/458">https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/458</a></p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573692021-11-12T06:59:41ZChristian Borchertccb056@gmail.com
<ul></ul><p>Viktor Gurov wrote in <a href="#note-2">#note-2</a>:</p>
<blockquote>
<p><a class="external" href="https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/458">https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/458</a></p>
</blockquote>
<p>Hi Viktor,</p>
<p>That link doesn't work for me</p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573702021-11-12T07:11:14ZViktor Gurov
<ul><li><strong>File</strong> <i>458.diff</i> added</li></ul><p>Christian Borchert wrote in <a href="#note-3">#note-3</a>:</p>
<blockquote>
<p>Viktor Gurov wrote in <a href="#note-2">#note-2</a>:</p>
<blockquote>
<p><a class="external" href="https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/458">https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/458</a></p>
</blockquote>
<p>Hi Viktor,</p>
<p>That link doesn't work for me</p>
</blockquote>
<p>You can try to test the attached patch</p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573772021-11-12T12:19:39ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Pull Request Review</i></li><li><strong>Assignee</strong> set to <i>Viktor Gurov</i></li><li><strong>Target version</strong> set to <i>CE-Next</i></li><li><strong>Plus Target Version</strong> set to <i>Plus-Next</i></li></ul> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573782021-11-12T12:43:11ZChristian Borchertccb056@gmail.com
<ul></ul><p>Thanks Viktor,</p>
<p>I believe I applied the changes to the files correctly - where does pfsense save the ntp.conf file - I want to verify the changes are made as expected to the file</p>
<p>-Christian</p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573792021-11-12T13:20:23ZChristian Borchertccb056@gmail.com
<ul></ul><p>OK - I was able to find the ntpd.conf file in pfsense's /var/etc directory</p>
<p>Looks like it is specifying server/pool/peer as selected in the webgui</p>
<p>The documentation recommends the following:<br /><em>A peer is configured in symmetric active mode using the peer command and specifying the other peer DNS name or IPv4 or IPv6 address. The burst and iburst options should not be used in symmetric modes, as this can upset the intended symmetry of the protocol and result in spurious duplicate or dropped messages.</em></p>
<p><a class="external" href="https://www.eecis.udel.edu/~mills/ntp/html/assoc.html">https://www.eecis.udel.edu/~mills/ntp/html/assoc.html</a></p>
<p>However, when Peer is selected in the webgui, iburst is configured in ntpd.conf</p>
<p>Can this be changed to match the recommendation above?</p>
<p>Thanks,<br />-Christian</p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573822021-11-13T02:03:13ZViktor Gurov
<ul><li><strong>File</strong> deleted (<del><i>458.diff</i></del>)</li></ul> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573832021-11-13T02:04:16ZViktor Gurov
<ul><li><strong>File</strong> <i>458 (1).diff</i> added</li></ul><p>Christian Borchert wrote in <a href="#note-7">#note-7</a>:</p>
<blockquote>
<p>OK - I was able to find the ntpd.conf file in pfsense's /var/etc directory</p>
<p>Looks like it is specifying server/pool/peer as selected in the webgui</p>
<p>The documentation recommends the following:<br /><em>A peer is configured in symmetric active mode using the peer command and specifying the other peer DNS name or IPv4 or IPv6 address. The burst and iburst options should not be used in symmetric modes, as this can upset the intended symmetry of the protocol and result in spurious duplicate or dropped messages.</em></p>
<p><a class="external" href="https://www.eecis.udel.edu/~mills/ntp/html/assoc.html">https://www.eecis.udel.edu/~mills/ntp/html/assoc.html</a></p>
<p>However, when Peer is selected in the webgui, iburst is configured in ntpd.conf</p>
<p>Can this be changed to match the recommendation above?</p>
<p>Thanks,<br />-Christian</p>
</blockquote>
<p>Thanks for info</p>
<p>You can re-test the attached patch<br />Please read <a class="external" href="https://docs.netgate.com/pfsense/en/latest/development/system-patches.html">https://docs.netgate.com/pfsense/en/latest/development/system-patches.html</a></p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573842021-11-13T07:47:21ZChristian Borchertccb056@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/3939">clipboard-202111130746-qzaqm.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3939/clipboard-202111130746-qzaqm.png">clipboard-202111130746-qzaqm.png</a> added</li><li><strong>File</strong> <a href="/attachments/3940">clipboard-202111130747-iaxc7.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3940/clipboard-202111130747-iaxc7.png">clipboard-202111130747-iaxc7.png</a> added</li></ul><p>Thanks Viktor,</p>
<p>I installed the "System_Patches" package, reverted to backup copies I made of system.inc and services_ntpd.php, and then installed the newly revised patch.</p>
<p>the peer line in ntpd.conf now correcly does not have the iburst flag, but now it is missing the host address</p>
<p><img src="https://redmine.pfsense.org/attachments/download/3939/clipboard-202111130746-qzaqm.png" alt="" /></p>
<p><img src="https://redmine.pfsense.org/attachments/download/3940/clipboard-202111130747-iaxc7.png" alt="" /></p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573852021-11-13T08:22:12ZChristian Borchertccb056@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/3941">clipboard-202111130822-wawmh.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3941/clipboard-202111130822-wawmh.png">clipboard-202111130822-wawmh.png</a> added</li></ul><p>I'm not sure - but I think we need an 'else' added to the code:</p>
<p><img src="https://redmine.pfsense.org/attachments/download/3941/clipboard-202111130822-wawmh.png" alt="" /></p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573862021-11-13T08:35:20ZViktor Gurov
<ul><li><strong>File</strong> <a href="/attachments/3942">458 (2).diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3942/458%20(2).diff">458 (2).diff</a> added</li></ul><p>Christian Borchert wrote in <a href="#note-11">#note-11</a>:</p>
<blockquote>
<p>I'm not sure - but I think we need an 'else' added to the code:</p>
<p><img src="https://redmine.pfsense.org/attachments/download/3941/clipboard-202111130822-wawmh.png" alt="" /></p>
</blockquote>
<p>Thank you!<br />fixed</p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573872021-11-13T08:35:32ZViktor Gurov
<ul><li><strong>File</strong> deleted (<del><i>458 (1).diff</i></del>)</li></ul> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=573902021-11-13T12:34:24ZChristian Borchertccb056@gmail.com
<ul></ul><p>Awesome! Thank you Viktor.</p>
<p>Running this latest revision and it all looks good to me.</p>
<p>There was a bounty attached to this request - do you have a Paypal?</p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=574122021-11-15T08:20:10ZViktor Gurov
<ul><li><strong>Status</strong> changed from <i>Pull Request Review</i> to <i>Feedback</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="NTP Peer mode. Implements #11496" href="https://redmine.pfsense.org/projects/pfsense/repository/2/revisions/0cfd008330b543a1674787cb031507fb1951a1f9">0cfd008330b543a1674787cb031507fb1951a1f9</a>.</p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=574682021-11-19T06:30:12ZViktor Gurov
<ul><li><strong>Target version</strong> changed from <i>CE-Next</i> to <i>2.6.0</i></li><li><strong>Plus Target Version</strong> changed from <i>Plus-Next</i> to <i>22.01</i></li></ul> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=575222021-11-24T00:25:34ZViktor Gurov
<ul></ul><p>works as expected on 2.6.0.a.20211123.0600<br />but I don't see this option on 22.01.a.20211122.0600</p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=576422021-12-03T12:29:37ZJim Pingle
<ul><li><strong>Subject</strong> changed from <i>NTP Peer</i> to <i>Support for NTP Peer mode</i></li></ul><p>Updating subject for release notes.</p> pfSense - Feature #11496: Support for NTP Peer modehttps://redmine.pfsense.org/issues/11496?journal_id=578272021-12-16T03:27:14ZDanilo Zrenjanin
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>Tested against:<br /><pre>
2.6.0-BETA (amd64)
built on Thu Dec 16 06:22:38 UTC 2021
FreeBSD 12.3-STABLE
</pre></p>
<p>You can choose Pool, Server, and Peer types.</p>
<p>Resolving the ticket.</p>