Project

General

Profile

Actions
Copy link

Bug #11946

closed

Custom value for AutoConfigBackup schedule Hours is not shown when loading the settings page

Added by Jim Pingle over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Backup / Restore
Target version:
2.5.2
Start date:
05/21/2021
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.01
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

When ACB is set to use a schedule on services_acb_settings.php, a the hour value from config.xml is not populated on the page. It always loads at 0. The correct value is placed into config.xml and is used as expected, but it is not shown to the user on the page.

If the user is not careful, the next time they visit the page to make a change, their chosen hour will reset to 0 unless they re-add their custom value.

Actions
Copy link
 #1

Updated by Michael Spears over 3 years ago

Jim Pingle wrote:

When ACB is set to use a schedule on services_acb_settings.php, a the hour value from config.xml is not populated on the page. It always loads at 0. The correct value is placed into config.xml and is used as expected, but it is not shown to the user on the page.

If the user is not careful, the next time they visit the page to make a change, their chosen hour will reset to 0 unless they re-add their custom value.

I reproduced this.

Actions
Copy link
 #3

Updated by Jim Pingle over 3 years ago

  • Status changed from New to Pull Request Review
Actions
Copy link
 #4

Updated by Renato Botelho over 3 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Viktor Gurov

PR has been merged. Thanks!

Actions
Copy link
 #5

Updated by Max Leighton over 3 years ago

Tested in 2.6.0. The specified hour will now stay on the page when after navigating away and navigating back.

However, I'm still seeing this in

21.09-DEVELOPMENT (arm64)
built on Sat Jun 05 01:09:01 EDT 2021
FreeBSD 12.2-STABLE

Actions
Copy link
 #6

Updated by Renato Botelho over 3 years ago

Cherry-picked to 2.5.2-RC

Actions
Copy link
 #7

Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Closed

Works with the latest RELENG_2_5_2 code in place.

Actions
Copy link
 #8

Updated by Jim Pingle over 3 years ago

  • Subject changed from AutoConfigBackup schedule custom hour value lost on page load to Custom value for AutoConfigBackup schedule Hours is not shown when loading the settings page

Updating subject for release notes.

Actions
Copy link
 #9

Updated by Jim Pingle about 3 years ago

  • Plus Target Version changed from 21.09 to 22.01
Actions
Copy link

Also available in: Atom PDF