Project

General

Profile

Actions

Todo #11983

closed

Hide "Reboot and run a filesystem check" for ZFS systems

Added by Jim Pingle 5 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Diagnostics
Target version:
Start date:
06/01/2021
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
21.09
Release Notes:
Default

Description

ZFS does not have a fsck utility, so the option to reboot and run a filesystem check does not make sense to offer to ZFS systems.

Even in cases where a check is indicated, zpool scrub operations do not need to be run in single user mode, so the option is unnecessary in those cases as well.

The option is current present in the CLI reboot menu and in the GUI under Diagnostics > Reboot (diag_reboot.php), and should be hidden from both when the system is using ZFS.

Actions #2

Updated by Jim Pingle 5 months ago

  • Status changed from New to Pull Request Review
Actions #3

Updated by Darin May 5 months ago

I'm running 21.05 on an sg-3100 and I don't have the fsck option on my reboot menu; should I?

Actions #4

Updated by Jim Pingle 5 months ago

Darin May wrote:

I'm running 21.05 on an sg-3100 and I don't have the fsck option on my reboot menu; should I?

No, that feature is not compatible with ARM systems, same with the option to reboot into single user mode. Both rely on nextboot which isn't supported there in FreeBSD yet.

Actions #5

Updated by Renato Botelho 4 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Viktor Gurov

PR has been merged. Thanks!

Actions #6

Updated by Viktor Gurov 4 months ago

  • % Done changed from 0 to 100
Actions #7

Updated by Jordan Greene 3 months ago

diagnostics>reboot only presents "Normal reboot" and "Reroot" as choices on system using ZFS running 21.09.a.20210723.0100

Actions #8

Updated by Jim Pingle 3 months ago

  • Status changed from Feedback to Resolved

Same is also true on 2.6.0 snapshots. Closing.

Actions

Also available in: Atom PDF