Bug #12249
open
Long configuration revision reasons can cause AutoConfigBackup upload to fail
100%
Description
HAProxy makes changes to config.xml with extremely large commit messages (> 2K chars) This exceeds the capacity of the ACB system causing backups to be rejected/discarded.
Example commit message:
"admin@172.16.1.2 (Local Database): Services: HAProxy: Frontend modified 'SSLFrontEnd' pool: advanced: "IyBSZW1vdmUgaGVhZGVycyB0aGF0IGV4cG9zZSBzZWN1cml0eS1zZW5zaXRpdmUgaW5mb3JtYXRpb24uDQpyc3BpZGVsIF5TZXJ2ZXI6LiokDQpyc3BpZGVsIF5YLVBvd2VyZWQtQnk6LiokDQpyc3BpZGVsIF5YLUFzcE5ldC1WZXJzaW9uOi4qJA0KDQojIGFkZCBzb21lIHNlY3VyaXR5IHJlbGF0ZWQgaGVhZGVycw0KI3JzcGFkZCBDb250ZW50LVNlY3VyaXR5LVBvbGljeTpcIGRlZmF1bHQtc3JjXCBcYGh0dHBzOlwgZGF0YTpcIFzigJh1bnNhZmUtaW5saW5lXFzigJlcIFxcJ3Vuc2FmZS1ldmFsXCcNCiNyc3BhZGQgQ29udGVudC1TZWN1cml0eS1Qb2xpY3k6XCBkZWZhdWx0LXNyY1wgJ3NlbGYnDQoNCnJzcGFkZCBYLUNvbnRlbnQtVHlwZS1PcHRpb25zOlwgbm9zbmlmZg0KcnNwYWRkIFgtWHNzLVByb3RlY3Rpb246XCAxO1wgbW9kZT1ibG9jaw0KcnNwYWRkIFgtRnJhbWUtT3B0aW9uczpcIFNBTUVPUklHSU4NCiNyc3BhZGQgU3RyaWN0LVRyYW5zcG9ydC1TZWN1cml0eTpcIG1heC1hZ2U9MTU1NTIwMDA7XCBpbmNsdWRlU3ViRG9tYWlucztcIHByZWxvYWQNCnJzcGFkZCBSZWZlcnJlci1Qb2xpY3k6XCBzdHJpY3Qtb3JpZ2luLXdoZW4tY3Jvc3Mtb3JpZ2luDQpyc3BhZGQgRmVhdHVyZS1Qb2xpY3k6XCAnbm9uZScNCnJzcGFkZCBFeHBlY3QtQ1Q6XCBtYXgtYWdlPTg2NDAwDQojRXhwZWN0LUNUOiBtYXgtYWdlPTg2NDAwLCBlbmZvcmNlDQoNCg==" -> "IyBSZW1vdmUgaGVhZGVycyB0aGF0IGV4cG9zZSBzZWN1cml0eS1zZW5zaXRpdmUgaW5mb3JtYXRpb24uDQpyc3BpZGVsIF5TZXJ2ZXI6LiokDQpyc3BpZGVsIF5YLVBvd2VyZWQtQnk6LiokDQpyc3BpZGVsIF5YLUFzcE5ldC1WZXJzaW9uOi4qJA0KDQojIGFkZCBzb21lIHNlY3VyaXR5IHJlbGF0ZWQgaGVhZGVycw0KI3JzcGFkZCBDb250ZW50LVNlY3VyaXR5LVBvbGljeTpcIGRlZmF1bHQtc3JjXCBcYGh0dHBzOlwgZGF0YTpcIFzigJh1bnNhZmUtaW5saW5lXFzigJlcIFxcJ3Vuc2FmZS1ldmFsXCcNCiNyc3BhZGQgQ29udGVudC1TZWN1cml0eS1Qb2xpY3k6XCBkZWZhdWx0LXNyY1wgJ3NlbGYnDQoNCnJzcGFkZCBYLUNvbnRlbnQtVHlwZS1PcHRpb25zOlwgbm9zbmlmZg0KcnNwYWRkIFgtWHNzLVByb3RlY3Rpb246XCAxO1wgbW9kZT1ibG9jaw0KcnNwYWRkIFgtRnJhbWUtT3B0aW9uczpcIFNBTUVPUklHSU4NCiNyc3BhZGQgU3RyaWN0LVRyYW5zcG9ydC1TZWN1cml0eTpcIG1heC1hZ2U9MTU1NTIwMDA7XCBpbmNsdWRlU3ViRG9tYWlucztcIHByZWxvYWQNCnJzcGFkZCBSZWZlcnJlci1Qb2xpY3k6XCBzdHJpY3Qtb3JpZ2luLXdoZW4tY3Jvc3Mtb3JpZ2luDQpyc3BhZGQgRmVhdHVyZS1Qb2xpY3k6XCAnbm9uZScNCnJzcGFkZCBFeHBlY3QtQ1Q6XCBtYXgtYWdlPTg2NDAwDQojRXhwZWN0LUNUOiBtYXgtYWdlPTg2NDAwLCBlbmZvcmNlDQpvcHRpb24gZm9yd2FyZGZvcg0KDQo=""
HAProxy should be updated to:
- Use more concise commit messages
- Bypass ACB when the change is not configuration related
Updated by Anonymous over 3 years ago
- Assignee deleted (
Anonymous)
The string "-NoReMoTeBaCkUp" can be added to a commit message to prevent it from being synced to ACB. The string is automatically removed from the message.
Updated by Viktor Gurov about 3 years ago
config.xml file size should be checked before upload, and produce an info box with "ACB config.xml size limit exceed" error in such cases
Updated by Jim Pingle over 2 years ago
- Category changed from Backup / Restore to Auto Configuration Backup
- Target version changed from Plus-Next to CE-Next
Updated by Jim Pingle 16 days ago
- Subject changed from HAProxy causing failed ACB backups to Long configuration revision reasons can cause ACB backup to fail
- Status changed from New to In Progress
- Assignee set to Jim Pingle
- Target version changed from CE-Next to 2.8.0
- Plus Target Version changed from Plus-Next to 25.03
- Affected Version set to All
Fixing this as a part of what I'm already working on, best option is to truncate the reason to the limit supported by the server (1024 chars) before upload. That wouldn't affect the reason inside the config.xml, just what is displayed on the service.
Updated by Jim Pingle 16 days ago
- Subject changed from Long configuration revision reasons can cause ACB backup to fail to Long configuration revision reasons can cause AutoConfigBackup upload to fail
Updated by Jim Pingle 14 days ago
- Status changed from In Progress to Feedback
- % Done changed from 0 to 100
Applied in changeset c81106eb27b31ee4738addc45798ddc10ff6c841.