https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162021-08-12T22:37:53ZpfSense bugtrackerpfSense Packages - Bug #12251: Wireguard 0.1.5 - ignores "KeepAlive" parameter if empty (instead of disabling)https://redmine.pfsense.org/issues/12251?journal_id=556742021-08-12T22:37:53ZChristian McDonaldcmcdonald@netgate.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li><li><strong>Assignee</strong> set to <i>Christian McDonald</i></li><li><strong>Target version</strong> set to <i>Future</i></li><li><strong>Affected Plus Version</strong> deleted (<del><i>21.05.1</i></del>)</li><li><strong>Affected Architecture</strong> <i>All</i> added</li><li><strong>Affected Architecture</strong> deleted (<del><i>SG-3100</i></del>)</li></ul><p>Restarting the service will work around this in the mean time</p> pfSense Packages - Bug #12251: Wireguard 0.1.5 - ignores "KeepAlive" parameter if empty (instead of disabling)https://redmine.pfsense.org/issues/12251?journal_id=557282021-08-13T20:39:32Z→ luckman212luke.hamburg@gmail.com
<ul></ul><p>Thanks. I ended up setting it to a high value, e.g. 86400</p> pfSense Packages - Bug #12251: Wireguard 0.1.5 - ignores "KeepAlive" parameter if empty (instead of disabling)https://redmine.pfsense.org/issues/12251?journal_id=558892021-08-21T21:46:16Z→ luckman212luke.hamburg@gmail.com
<ul></ul><p>Hmm, seems like 86400 is not a valid value after all. It got silently accepted but eventually caused the tunnel to fail. Just noticed this! (status page was throwing up some wild values). I only saw the true error when dropping into the console:</p>
<pre>
# wg syncconf tun_wg0 /usr/local/etc/wireguard/tun_wg0.conf
Persistent keepalive interval is neither 0/off nor 1-65535: `86400'
Configuration parsing error
</pre>
<p>There ought to be some input validation to make sure this range is respected.</p> pfSense Packages - Bug #12251: Wireguard 0.1.5 - ignores "KeepAlive" parameter if empty (instead of disabling)https://redmine.pfsense.org/issues/12251?journal_id=567422021-10-13T14:47:50ZAdam Cooper
<ul></ul><p>→ luckman212 wrote in <a href="#note-3">#note-3</a>:</p>
<blockquote>
<p>Hmm, seems like 86400 is not a valid value after all. It got silently accepted but eventually caused the tunnel to fail. Just noticed this! (status page was throwing up some wild values). I only saw the true error when dropping into the console:</p>
<p>[...]</p>
<p>There ought to be some input validation to make sure this range is respected.</p>
</blockquote>
<p>I've raised PR 151 (<a class="external" href="https://github.com/theonemcdonald/pfSense-pkg-WireGuard/pull/151">https://github.com/theonemcdonald/pfSense-pkg-WireGuard/pull/151</a>) to resolve these two issues.</p>
<p>Now the default empty value (or 0 if you wanted to be super explicit) will be written out to the configs instead of omitting them.<br />And the user will be informed if any value not in 0 - 65535 is supplied, preventing the silent accept and error</p> pfSense Packages - Bug #12251: Wireguard 0.1.5 - ignores "KeepAlive" parameter if empty (instead of disabling)https://redmine.pfsense.org/issues/12251?journal_id=572552021-10-30T12:43:29ZAdam Cooper
<ul></ul><p>PR has been merged, should be in the next release so ticket can be closed</p> pfSense Packages - Bug #12251: Wireguard 0.1.5 - ignores "KeepAlive" parameter if empty (instead of disabling)https://redmine.pfsense.org/issues/12251?journal_id=586292022-01-26T08:10:37ZViktor Gurov
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Feedback</i></li></ul><p>Merged</p> pfSense Packages - Bug #12251: Wireguard 0.1.5 - ignores "KeepAlive" parameter if empty (instead of disabling)https://redmine.pfsense.org/issues/12251?journal_id=586302022-01-26T08:11:02ZViktor Gurov
<ul><li><strong>Target version</strong> deleted (<del><i>Future</i></del>)</li></ul> pfSense Packages - Bug #12251: Wireguard 0.1.5 - ignores "KeepAlive" parameter if empty (instead of disabling)https://redmine.pfsense.org/issues/12251?journal_id=614802022-05-29T06:38:54ZAzamat Khakimyanov
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>Tested on 22.01</p>
<p>When I used empty 'Keep Alive' field, I got in config: <em><strong>PersistentKeepalive = 0</strong></em></p>
<p>When I tried to use 'Keep Alive: 86400' I got: <em><strong>"The following input errors were detected: Keep alive interval must be in range 0-65535 (86400)."</strong></em></p>
<p>I marked this Bug as resolved</p>