Project

General

Profile

Actions
Copy link

Feature #12392

closed

Allow the selection of "any" interface in floating rules

Added by Marcos M over 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Rules / NAT
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default

Description

Currently, a floating rule can be created without specifying an interface which allows for filtering on interfaces not otherwise shown - e.g. loopback. It would be good to add "any" to the list to make the functionality more apparent.

Actions
Copy link
 #2

Updated by Jim Pingle almost 3 years ago

  • Status changed from New to Pull Request Review
  • Assignee set to Viktor Gurov
  • Target version set to CE-Next
  • Plus Target Version set to 22.05
Actions
Copy link
 #3

Updated by Viktor Gurov almost 3 years ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Jordan G almost 3 years ago

Any selection is present when creating a floating rule in 22.05.a.20220219.0600, wasn't fully sure how to validate the functionality of rules with 'any' selected

Actions
Copy link
 #5

Updated by Viktor Gurov almost 3 years ago

  • Status changed from Feedback to New

PHP error after editing rules on a non-floating page:

PHP Errors:
[21-Feb-2022 09:53:50 Europe/Moscow] PHP Warning:  
in_array() expects parameter 2 to be array, string given in /usr/local/www/firewall_rules_edit.php on line 867

fix:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/632

Actions
Copy link
 #6

Updated by Marcos M almost 3 years ago

I hit that php error once on 22.05, but I can't seem to reproduce it now to test the patch.

Edit: I was able to reproduce it multiple times, though it's somewhat inconsistent. The fix looks good.

Actions
Copy link
 #7

Updated by Jim Pingle almost 3 years ago

  • Status changed from New to Pull Request Review
  • Target version changed from CE-Next to 2.7.0
Actions
Copy link
 #8

Updated by Viktor Gurov almost 3 years ago

  • Status changed from Pull Request Review to Feedback
Actions
Copy link
 #9

Updated by Alhusein Zawi almost 3 years ago

  • Status changed from Feedback to Resolved

tested 2.7.0.a.20220305.0600 (interface: any) no php error.

Actions
Copy link
 #10

Updated by Jim Pingle over 2 years ago

  • Subject changed from Allow the selection of "any" interface in floating rules. to Allow the selection of "any" interface in floating rules

Updating subject for release notes.

Actions
Copy link

Also available in: Atom PDF