Project

General

Profile

Actions
Copy link

Bug #12871

closed

Some action buttons are always active for firewall rules, even if no rules are selected

Added by Viktor Gurov about 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Very Low
Assignee:
Viktor Gurov
Category:
Rules / NAT
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default
Affected Version:
2.7.0
Affected Architecture:

Description

"Delete", "Toggle" (#2505), and "Copy rule" (#8365) buttons at the bottom of the rules page are always active.
All of these buttons are clickable and show a popup/modal window without any effect.

Actions
Copy link
 #1

Updated by Kris Phillips about 2 years ago

The delete button being always available even without selection is present in 2.6/22.01 and 21.05.X/2.5.X. It does the same modal pop up even when no rules are selected.

Actions
Copy link
 #2

Updated by Viktor Gurov about 2 years ago

  • Assignee set to Viktor Gurov
  • Target version set to 2.7.0
  • Plus Target Version set to 22.05
Actions
Copy link
 #3

Updated by Jim Pingle about 2 years ago

  • Status changed from New to Pull Request Review
Actions
Copy link
 #4

Updated by Viktor Gurov about 2 years ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Christopher Cope about 2 years ago

Tested on

22.05-DEVELOPMENT (amd64)
built on Wed Mar 16 06:19:09 UTC 2022
FreeBSD 12.3-STABLE

and the buttons are disabled without a selection on the rule page; however, the category of this bug says Rules / NAT and the prior behavior is still present on all NAT pages. Port Forward, 1:1, Outbound, & NPt pages all have the save button active even without a selection.

Actions
Copy link
 #6

Updated by Jim Pingle about 2 years ago

  • Status changed from Feedback to Resolved

This issue was just for the firewall rules page which is good now. The other pages should get a fresh Redmine issue if they have problems.

Actions
Copy link
 #7

Updated by Viktor Gurov about 2 years ago

Christopher Cope wrote in #note-5:

Tested on
[...]

and the buttons are disabled without a selection on the rule page; however, the category of this bug says Rules / NAT and the prior behavior is still present on all NAT pages. Port Forward, 1:1, Outbound, & NPt pages all have the save button active even without a selection.

see the new redmine issue #12966

Actions
Copy link
 #8

Updated by Jim Pingle about 2 years ago

  • Subject changed from Some action buttons are always active, even if no rule is selected to Some action buttons are always active, even if no rules are selected

Updating subject for release notes.

Actions
Copy link
 #9

Updated by Jim Pingle about 2 years ago

  • Subject changed from Some action buttons are always active, even if no rules are selected to Some action buttons are always active for firewall rules, even if no rules are selected

Updating subject for release notes.

Actions
Copy link

Also available in: Atom PDF