Project

General

Profile

Actions
Copy link

Feature #12968

closed

Button to clear previous packet capture data

Added by Phil Wardt over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Jim Pingle
Category:
Packet Capture
Target version:
2.7.0
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default

Description

Packet Capture window:
When there is a log file, show a "Clear Log" button to delete the last log without having to drop to cli

This commit is in the same direction of my last one for Package NMap at https://redmine.pfsense.org/issues/12963

Tested properly with Start, Stop, Download, View and no logs to display actions

Git commit in comments, patch attached + picture of change

Files

Download all files
diag_packet_capture.patch (974 Bytes) diag_packet_capture.patch Phil Wardt, 03/21/2022 02:36 PM
Capture.JPG (45.1 KB) Capture.JPG Phil Wardt, 03/21/2022 02:36 PM
diag_packet_capture.patch-v2.patch (1.04 KB) diag_packet_capture.patch-v2.patch Phil Wardt, 03/22/2022 02:13 PM
Capture.JPG (41 KB) Capture.JPG Phil Wardt, 03/24/2022 01:57 PM
Actions
Copy link
 #1

Updated by Viktor Gurov over 2 years ago

Actions
Copy link
 #2

Updated by Phil Wardt over 2 years ago

Viktor Gurov wrote in #note-1:

Please create a pull request with your changes:
https://docs.netgate.com/pfsense/en/latest/development/pull-request.html

Sorry, I forgot to post the link:
https://github.com/pfsense/pfsense/pull/4564

Actions
Copy link
 #3

Updated by Jim Pingle over 2 years ago

  • Subject changed from Packet capture: add clear log button to Packet capture: Add button to clear previous capture data
  • Status changed from New to Pull Request Review
  • Assignee deleted (Jim Pingle)
Actions
Copy link
 #5

Updated by Jim Pingle over 2 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Jim Pingle
  • Target version set to 2.7.0
  • Plus Target Version set to 22.05

PR Merged

Actions
Copy link
 #6

Updated by Phil Wardt over 2 years ago

I just noticed you have a delete icon
I pushed another enhancement with a proper delete icon:
https://github.com/pfsense/pfsense/pull/4565

Actions
Copy link
 #7

Updated by Jim Pingle over 2 years ago

PR merged

Actions
Copy link
 #8

Updated by Christopher Cope over 2 years ago

  • Status changed from Feedback to Resolved

It functions as expected on

22.05-DEVELOPMENT (amd64)
built on Mon Mar 28 06:21:39 UTC 2022
FreeBSD 12.3-STABLE

Marking resolved.

Actions
Copy link
 #9

Updated by Jim Pingle over 2 years ago

  • Subject changed from Packet capture: Add button to clear previous capture data to Button to clear previous packet capture data

Updating subject for release notes.

Actions
Copy link

Also available in: Atom PDF