Bug #13088
closedRapidly clicking certain options on OpenVPN Client Overrides can cause hide/show field behavior to invert
100%
Description
in client specific overrides, NTP and DNS options: use javascript instead of toggles class because the latter causes inverted results when repeating clicks too quickly. This also matches the code used in the server page
Completes OpenVPN GUI fixes:
https://redmine.pfsense.org/issues/13087
Files
Updated by Phil Wardt over 2 years ago
- File vpn_openvpn_csc.patch vpn_openvpn_csc.patch added
Updated by Danilo Zrenjanin over 2 years ago
I replicated the issue with inverted results when repeating clicks too quickly on 22.05.r.20220604.1403.
After applying the patch, it works fine.
Updated by Danilo Zrenjanin over 1 year ago
- Status changed from New to Pull Request Review
I can confirm this behavior is present on the:
22.05-RELEASE (amd64) built on Wed Jun 22 18:56:13 UTC 2022 FreeBSD 12.3-STABLE
The patch fixes the issue. It can be merged.
Updated by Lev Prokofev over 1 year ago
Can't replicate the issue on
23.05-DEVELOPMENT (amd64)
built on Mon Jan 09 06:04:59 UTC 2023
FreeBSD 14.0-CURRENT
Updated by Lev Prokofev over 1 year ago
Correcting,
Replicable on 23.05 and 23.01
Updated by Jim Pingle over 1 year ago
- Target version set to 2.7.0
- Plus Target Version set to 23.05
Updated by Jim Pingle over 1 year ago
- Plus Target Version changed from 23.05 to 23.09
Updated by Jim Pingle over 1 year ago
- Status changed from Pull Request Review to Feedback
- % Done changed from 0 to 100
Applied in changeset e9a36ae328837f7744e22dd85d1ef8dd82e897f4.
Updated by Jim Pingle over 1 year ago
- Status changed from Feedback to Resolved
Working OK on the latest build as far as I can tell.
Updated by Jim Pingle about 1 year ago
- Subject changed from OpenVPN Client Overrides: properly hide/show form fields to Rapidly clicking certain options on OpenVPN Client Overrides can cause hide/show field behavior to invert
Updating subject for release notes.