https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162022-05-17T04:35:33ZpfSense bugtrackerpfSense - Regression #13178: Incorrect usage of DSCP hex valuehttps://redmine.pfsense.org/issues/13178?journal_id=612012022-05-17T04:35:33ZViktor Gurov
<ul><li><strong>Assignee</strong> set to <i>Viktor Gurov</i></li><li><strong>Target version</strong> set to <i>2.7.0</i></li><li><strong>Plus Target Version</strong> set to <i>22.05</i></li></ul><p>It possible to use the "tos cs1" format, instead of the hex value.</p>
<p>fix:<br /><a class="external" href="https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/789">https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/789</a></p> pfSense - Regression #13178: Incorrect usage of DSCP hex valuehttps://redmine.pfsense.org/issues/13178?journal_id=612052022-05-17T07:23:24ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Pull Request Review</i></li></ul> pfSense - Regression #13178: Incorrect usage of DSCP hex valuehttps://redmine.pfsense.org/issues/13178?journal_id=612062022-05-17T07:40:10ZViktor Gurov
<ul><li><strong>Status</strong> changed from <i>Pull Request Review</i> to <i>Feedback</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="DSCP usage optimization. Fixes #13178" href="https://redmine.pfsense.org/projects/pfsense/repository/2/revisions/726c2c891d56132a57fc6ba33a9d62a37223743d">726c2c891d56132a57fc6ba33a9d62a37223743d</a>.</p> pfSense - Regression #13178: Incorrect usage of DSCP hex valuehttps://redmine.pfsense.org/issues/13178?journal_id=612432022-05-18T10:00:21ZJoshua Niles
<ul></ul><p>The fix works, thank you.</p>
<p>It's worth noting that for the System_Patches package on 2.6.0 <strong>b7b78ea1b14555972efaf7e6c47e48709ad1c199</strong> must be applied before <strong>726c2c891d56132a57fc6ba33a9d62a37223743d</strong> and that their order is important for auto apply.</p>
<p>Would be nice to have this in the next 2.6.x release.</p>
By the way the rule creation UI has 3 hex options in the DSCP drop-down:
<ul>
<li>0x01</li>
<li>0x02</li>
<li>0x04</li>
</ul>
Those are all used directly by pf as ToS hex values. I'm not sure that 0x01 is even a valid ToS option, and I'm guessing that those hex options are intended to refer to the DSCP hex where:
<ul>
<li>0x01 DSCP = 0x04 ToS</li>
<li>0x02 DSCP = 0x08 ToS</li>
<li>0x04 DSCP = 0x10 ToS</li>
</ul>
<p>If I'm wrong I think it'd make sense to add "ToS" to those options, since it is a drop-down for DSCP.</p>
<p>Neither of these patches affected the behavior when choosing those 3 hex options, maybe it was a bug introduced in 2.6.0, or I am just confused. I don't have a 2.5.2 system to test with.</p> pfSense - Regression #13178: Incorrect usage of DSCP hex valuehttps://redmine.pfsense.org/issues/13178?journal_id=615562022-05-31T13:42:15ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>This is OK as-is for now. We could consider the other change as a separate request for the next release if needed.</p>