Project

General

Profile

Actions

Bug #13448

closed

table selection has impossibly poor contrast in dark theme

Added by Sean McBride 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Category:
Web Interface
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
2.6.0
Affected Architecture:

Description

In UI that uses a table, and requires selecting a row (like with pfBlockerNG under IP > IP Interface/Rules Configuration) the colour of a selected row vs an unselected row is totally indistinguishable with the dark theme.

See attached screenshots, in both themes the same rows are selected, namely "WAN" in the top table, and "LAN" in the bottom table. With the dark theme it looks like nothing is selected.


Files

Light.png (71.3 KB) Light.png Sean McBride, 08/25/2022 04:45 PM
Dark.png (71.3 KB) Dark.png Sean McBride, 08/25/2022 04:46 PM
855.diff (451 Bytes) 855.diff Lev Prokofev, 09/02/2022 07:29 AM
clipboard-202209021532-v63um.png (19.9 KB) clipboard-202209021532-v63um.png Lev Prokofev, 09/02/2022 07:32 AM
Actions #1

Updated by Christopher Cope 3 months ago

  • Status changed from New to Pull Request Review
  • Assignee set to Christopher Cope
Actions #2

Updated by Christopher Cope 3 months ago

  • Status changed from Pull Request Review to Feedback

Merged.

Actions #3

Updated by odo maitre 3 months ago

Christopher Cope wrote in #note-1:

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/855

What was merged? This link is not functional.

Actions #4

Updated by Lev Prokofev 3 months ago

The color changed to #009688

Looks much better.

Actions #5

Updated by odo maitre 3 months ago

Lev Prokofev wrote in #note-4:

The color changed to #009688

Indeed - thank you! (Also for the 855.diff )

Actions #6

Updated by Christopher Cope 2 months ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF