Regression #13999: PHP error in NTP widget and status with GPS data - pfSense - pfSense bugtracker

Actions

Copy link

Regression #13999

closed

PHP error in NTP widget and status with GPS data

Added by anthony mushamel almost 2 years ago. Updated over 1 year ago.

Status:

Resolved

Priority:

Normal

Assignee:

Jim Pingle

Category:

NTPD

Target version:

2.7.0

Start date:

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

23.05

Release Notes:

Default

Affected Version:

2.7.0

Affected Architecture:

amd64

Description

I have had this issue since the beta and I am still having it on 23.01 final.
I put the NTP widget on my home screen and it works fine. After a bit of time or a refresh of the page, I get the following error

Fatal error: Uncaught TypeError: Unsupported operand types: string / float in /usr/local/www/widgets/widgets/ntp_status.widget.php:121 Stack trace: #0 {main} thrown in /usr/local/www/widgets/widgets/ntp_status.widget.php on line 121 PHP ERROR: Type: 1, File: /usr/local/www/widgets/widgets/ntp_status.widget.php, Line: 121, Message: Uncaught TypeError: Unsupported operand types: string / float in /usr/local/www/widgets/widgets/ntp_status.widget.php:121 Stack trace: #0 {main} thrown

Here is the crash report
Crash report begins. Anonymous machine information:

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #0 plus-RELENG_23_01-n256037-6e914874a5e: Fri Feb 10 20:30:29 UTC 2023 root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/obj/amd64/VDZvZksF/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/sources/FreeBS

Crash report details:

PHP Errors:
[20-Feb-2023 15:09:15 America/Los_Angeles] PHP Fatal error: Uncaught TypeError: Unsupported operand types: string / float in /usr/local/www/widgets/widgets/ntp_status.widget.php:121
Stack trace:
#0 {main}
thrown in /usr/local/www/widgets/widgets/ntp_status.widget.php on line 121

No FreeBSD crash data found.

Actions

Copy link

Updated by Jim Pingle almost 2 years ago

Tracker changed from Bug to Regression
Subject changed from NTP Widget suffers from PHP Fatal Error to PHP error in NTP widget/status with GPS data.
Status changed from New to In Progress
Assignee set to Jim Pingle
Target version set to 2.7.0
Affected Plus Version changed from 23.01 to 22.05

Looks like the exact same crash can happen on status_ntpd.php, both seem to need a GPS module present to trigger.

Actions

Copy link

Updated by Jim Pingle almost 2 years ago

Category changed from Dashboard to NTPD

Actions

Copy link

Updated by Jim Pingle almost 2 years ago

Status changed from In Progress to Feedback
% Done changed from 0 to 100

Applied in changeset pfsense:0e847960910ae9f14ca7b52c84be25fe4b9d1064.

Actions

Copy link

Updated by Jim Pingle almost 2 years ago

Project changed from pfSense Plus to pfSense
Subject changed from PHP error in NTP widget/status with GPS data. to PHP error in NTP widget and status with GPS data
Category changed from NTPD to NTPD
Affected Plus Version deleted (~~22.05~~)
Plus Target Version set to 23.05