Project

General

Profile

Actions

Todo #14186

closed

Improve DynDNS help text readability

Added by Bojan Bogojevic about 1 year ago. Updated 12 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Dynamic DNS
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
23.05
Release Notes:
Default

Description

  • To improve readability I've reordered hostname, username, password, zone id help texts alphabetically.
  • Changed 'type' to 'provider' for consistency (username help text).
  • Capitalized one instance of "dns" to "DNS" (ttl help text).
Actions #2

Updated by Jim Pingle about 1 year ago

  • Assignee set to Jim Pingle
  • Target version set to 2.7.0
  • Plus Target Version set to 23.05
Actions #3

Updated by Jim Pingle about 1 year ago

  • Status changed from Pull Request Review to Feedback

PR merged.

Actions #4

Updated by Chris Linstruth about 1 year ago

Looks good to me. @Bojan Bogojevic should probably weigh in to see if it is what was desired.

Actions #5

Updated by Bojan Bogojevic about 1 year ago

Chris Linstruth wrote in #note-4:

Looks good to me. @Bojan Bogojevic should probably weigh in to see if it is what was desired.

I like the improvement :).

edit: somehow commit f9f13d0 is not succeeding as Patch (Patches package) on 2.6.0 CE. I can't figure out why, but that commit does not properly fetches my changes, while on Github everything looks OK. Please double check I am not breaking stuff :).


Community Edition

    System
    Interfaces
    Firewall
    Services
    VPN
    Status
    Diagnostics
    Help

    SystemPatches

This page allows adding patches, either from the official code repository or pasted in from e-mail or other sources.
Use with caution!
View Custom Patch

From f9f13d00880ac3b925558f4517f2246886fdacf0 Mon Sep 17 00:00:00 2001
From: Bojan Bogojevic <20166636+Bojan023@users.noreply.github.com>
Date: Thu, 23 Mar 2023 10:17:28 +0100
Subject: [PATCH] Reorder DynDNS pasxsowrd help text alphabetically

---
 src/usr/local/www/services_dyndns_edit.php | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/usr/local/www/services_dyndns_edit.php b/src/usr/local/www/services_dyndns_edit.php
index 4740714c4b6..e7b467b5905 100644
--- a/src/usr/local/www/services_dyndns_edit.php
+++ b/src/usr/local/www/services_dyndns_edit.php
@@ -443,23 +443,23 @@ function build_if_list() {
     'Password',
     'password',
     $pconfig['password']
-))->setHelp('FreeDNS (freedns.afraid.org): Enter the "Token" provided by FreeDNS. The token is after update.php? for API v1 or after  u/ for v2.%1$s' .
-            'Azure: client secret of the AD application%1$s' .
-            'DNS Made Easy: Dynamic DNS Password%1$s' .
+))->setHelp('Azure: client secret of the AD application%1$s' .
+            'Cloudflare: Enter the Global API Key or API token with DNS edit permission on the provided zone.%1$s' .
+            'deSEC: Enter the API token.%1$s' .
             'DigitalOcean: Enter API token%1$s' .
-            'Route 53: Enter the Secret Access Key.%1$s' .
-            'GleSYS: Enter the API key.%1$s' .
+            'DNSExit: Enter the API Key.%1$s' .
+            'DNSimple: Enter the API token.%1$s' .
+            'DNS Made Easy: Dynamic DNS Password%1$s' .
             'Domeneshop: Enter the API secret.%1$s' .
             'Dreamhost: Enter the API Key.%1$s' .
+            'FreeDNS (freedns.afraid.org): Enter the "Token" provided by FreeDNS. The token is after update.php? for API v1 or after  u/ for v2.%1$s' .
             'Gandi LiveDNS: Enter API token%1$s' .
+            'GleSYS: Enter the API key.%1$s' .
             'GoDaddy: Enter the API secret.%1$s' .
-            'DNSimple: Enter the API token.%1$s' .
-            'DNSExit: Enter the API Key.%1$s' .
             'Linode: Enter the Personal Access Token.%1$s' .
             'Name.com: Enter the API token.%1$s' .
-            'Yandex: Yandex PDD Token.%1$s' .
-            'Cloudflare: Enter the Global API Key or API token with DNS edit permission on the provided zone.%1$s' .
-            'deSEC: Enter the API token.', '<br />');
+            'Route 53: Enter the Secret Access Key.%1$s' .
+            'Yandex: Yandex PDD Token.', '<br />');

 $section->addInput(new Form_Input(
     'zoneid',

Close

Custom System Patches
      Description     Fetch     Apply     Revert     View     Debug     Auto Apply     Actions
    DynDNS FQDN     

    DynDNS username     

    DynDNS password     

    DynDNS zoneid     

    DynDNS ttl     

Actions #6

Updated by Jim Pingle 12 months ago

  • Status changed from Feedback to Resolved

If you can't patch it with that one alone there is likely some other change that needs applied first. There were several other changes to Dynamic DNS between 2.6.0 and the current code base, you'd have to track down and apply them all. Sometimes you can get lucky and the lines a patch touches haven't changed in a long time, but that doesn't appear to be the case here.

Closing this out though since the changes appear to be good on snapshots.

Actions #7

Updated by Jim Pingle 12 months ago

  • Tracker changed from Feature to Todo
Actions

Also available in: Atom PDF