https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162023-03-31T07:46:06ZpfSense bugtrackerpfSense - Todo #14210: Proposed new Icons for Logs to make for more logical readinghttps://redmine.pfsense.org/issues/14210?journal_id=664862023-03-31T07:46:06ZJim Pingle
<ul><li><strong>File</strong> <a href="/attachments/4877">2023-03-31_08-42.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4877/2023-03-31_08-42.png">2023-03-31_08-42.png</a> added</li><li><strong>Assignee</strong> set to <i>Jim Pingle</i></li></ul><p>I'm open to changing the icons but personally I don't find either of those any better/worse than the current icons.</p>
<p>They are both in the FA version we have (<code>fa-minus-circle</code>, <code>fa-arrow-square-right</code>) but they make things even more inconsistent with other areas.</p>
<p>In the firewall rule list we use a checkmark (<code>fa-check</code>) on pass rules and an X (<code>fa-times</code>) on block rules. Using the circle outline versions of those looks better to me and is consistent.</p>
<p><img src="https://redmine.pfsense.org/attachments/download/4877/2023-03-31_08-42.png" alt="" /></p>
<p>Changing the icons is easy enough, just need to update the class attribute on the lines that output the easyrule links:</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/src/usr/local/www/status_logs_filter.php b/src/usr/local/www/status_logs_filter.php
index 599105f5f2..228ed9aaae 100644
</span><span class="gd">--- a/src/usr/local/www/status_logs_filter.php
</span><span class="gi">+++ b/src/usr/local/www/status_logs_filter.php
</span><span class="p">@@ -237,7 +237,7 @@</span> if (!$rawfilter) {
<i class="fa fa-info icon-pointer icon-primary" onclick="javascript:resolve_with_ajax('<?="{$rawsrcip}"; ?>');" title="<?=gettext("Click to resolve")?>">
</i>
- <a class="fa fa-minus-square-o icon-pointer icon-primary" href="easyrule.php?<?="action=block&amp;int={$int}&amp;src={$filterent['srcip']}&amp;ipproto={$ipproto}"; ?>" title="<?=gettext("EasyRule: Add to Block List")?>">
<span class="gi">+ <a class="fa fa-times-circle-o icon-pointer icon-primary" href="easyrule.php?<?="action=block&amp;int={$int}&amp;src={$filterent['srcip']}&amp;ipproto={$ipproto}"; ?>" title="<?=gettext("EasyRule: Add to Block List")?>">
</span> </a>
<?=$srcstr . '<span class="RESOLVE-' . $src_htmlclass . '"></span>'?>
<span class="p">@@ -246,7 +246,7 @@</span> if (!$rawfilter) {
<i class="fa fa-info icon-pointer icon-primary; ICON-<?= $dst_htmlclass; ?>" onclick="javascript:resolve_with_ajax('<?="{$rawdstip}"; ?>');" title="<?=gettext("Click to resolve")?>">
</i>
- <a class="fa fa-plus-square-o icon-pointer icon-primary" href="easyrule.php?<?="action=pass&amp;int={$int}&amp;proto={$proto}&amp;src={$filterent['srcip']}&amp;dst={$filterent['dstip']}&amp;dstport={$filterent['dstport']}&amp;ipproto={$ipproto}"; ?>" title="<?=gettext("EasyRule: Pass this traffic")?>">
<span class="gi">+ <a class="fa fa-check-circle-o icon-pointer icon-primary" href="easyrule.php?<?="action=pass&amp;int={$int}&amp;proto={$proto}&amp;src={$filterent['srcip']}&amp;dst={$filterent['dstip']}&amp;dstport={$filterent['dstport']}&amp;ipproto={$ipproto}"; ?>" title="<?=gettext("EasyRule: Pass this traffic")?>">
</span> </a>
<?=$dststr . '<span class="RESOLVE-' . $dst_htmlclass . '"></span>'?>
</td>
</code></pre>