Project

General

Profile

Actions

Bug #14576

closed

"Convert interface definitions" option is not respected when bulk copying rules

Added by Jim Pingle 9 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Rules / NAT
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.09
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

When using the "Copy" button to bulk copy rules from one interface to another, the "Convert interface definitions" option is not respected. It is always treated as if it's checked/enabled, resulting in the interface values being adjusted even if the user didn't opt into that behavior.

The JS handling that value doesn't appear to be correct, it's going by the "value" of the form field which is static, when it should be testing the "checked" property.

Actions #1

Updated by Jim Pingle 9 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #2

Updated by Danilo Zrenjanin 9 months ago

  • Status changed from Feedback to Resolved

Tested the patch against:

23.05.1-RELEASE (amd64)
built on Wed Jun 28 03:57:27 UTC 2023
FreeBSD 14.0-CURRENT

After applying the patch, the Convert interface definitions checkbox status is respected.

Ticket resolved.

Actions #3

Updated by Peter Moreno 9 months ago

How to apply the patch to 2.7-Release?
Regards!!

Actions #4

Updated by Jim Pingle 9 months ago

Peter Moreno wrote in #note-3:

How to apply the patch to 2.7-Release?
Regards!!

You can install the System Patches package and then create an entry for 77e168861ba43b3d6290df07fc04481c09174b28 to apply the fix.

Actions #5

Updated by Peter Moreno 9 months ago

I had apply the patch, now I can see the difference.
Fixed, thanks guys!!!

Actions #6

Updated by Jim Pingle 6 months ago

  • Target version changed from 2.8.0 to 2.7.1
Actions

Also available in: Atom PDF