Project

General

Profile

Actions

Bug #14695

closed

Copy function for User Manager Groups does not work for first group in list

Added by Dan Edwards 8 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
User Manager / Privileges
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.09
Release Notes:
Default
Affected Version:
Affected Architecture:
All

Description

It seems that https://redmine.pfsense.org/issues/12226 did not completely resolve this issue.

If you try to copy the first group in the list (gid doesn't seem to matter, just the fact it is the first listed group in the gui/config) it is only edited. Other groups are correctly copied though - have tried in 22.05 and 23.05.1 with same result on all. Using the copy button on the first group, opens the group edit form with the group name already populated - any changes on saving are made to the original group, other groups correctly open up the group form with no existing group name and on saving copy the original group settings to a new group.

Actions #1

Updated by Jim Pingle 8 months ago

  • Project changed from pfSense Plus to pfSense
  • Subject changed from Copy Group only edits existing group to Copy function for User Manager Groups does not work for first group in list
  • Category changed from User Manager / Privileges to User Manager / Privileges
  • Status changed from New to In Progress
  • Assignee set to Jim Pingle
  • Target version set to 2.8.0
  • Affected Plus Version deleted (23.05.1)
  • Plus Target Version set to 23.09

Not specific to Plus.

Looks like most of the tests checking if the duplicate action is being performed are done in a way that would end up being false for an ID of 0.

I have a fix, commit coming shortly.

Actions #2

Updated by Jim Pingle 8 months ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100
Actions #3

Updated by Danilo Zrenjanin 8 months ago

The patch fixes it.

I am marking this ticket resolved.

Actions #4

Updated by Danilo Zrenjanin 8 months ago

  • Status changed from Feedback to Resolved
Actions #5

Updated by Jim Pingle 5 months ago

  • Target version changed from 2.8.0 to 2.7.1
Actions

Also available in: Atom PDF