Project

General

Profile

Actions
Copy link

Bug #14741

closed
NP CM

PHP error in DNS Forwarder host overrides when the language is set to French

Bug #14741: PHP error in DNS Forwarder host overrides when the language is set to French

Added by Nicolas PISTER about 3 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Very High
Assignee:
Christian McDonald
Category:
DNS Forwarder
Target version:
2.9.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
25.11
Release Notes:
Default
Affected Version:
2.7.x
Affected Architecture:

Description

A PHP error occur when a user try to add or modify Host Override in DNS Forwarder module

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #1 RELENG_2_7_0-n255866-686c8d3c1f0: Wed Jun 28 04:21:19 UTC 2023     root@freebsd:/var/jenkins/workspace/pfSense-CE-snapshots-2_7_0-main/obj/amd64/LwYAddCr/var/jenkins/workspace/pfSense-CE-snapshots-2_7_0-main/sources/FreeBSD-src-REL

Crash report details:

PHP Errors:
[02-Sep-2023 11:55:24 Europe/Paris] PHP Fatal error:  Uncaught ValueError: Unknown format specifier "p" in /usr/local/www/classes/Form/Input.class.php:127
Stack trace:
#0 /usr/local/www/classes/Form/Input.class.php(127): sprintf('Nom de domaine ...', '<br />')
#1 /usr/local/www/services_dnsmasq_edit.php(85): Form_Input->setHelp('Domain of the h...', '<br />')
#2 {main}
  thrown in /usr/local/www/classes/Form/Input.class.php on line 127
[02-Sep-2023 11:58:37 Europe/Paris] PHP Fatal error:  Uncaught ValueError: Unknown format specifier "p" in /usr/local/www/classes/Form/Input.class.php:127
Stack trace:
#0 /usr/local/www/classes/Form/Input.class.php(127): sprintf('Nom de domaine ...', '<br />')
#1 /usr/local/www/services_dnsmasq_edit.php(85): Form_Input->setHelp('Domain of the h...', '<br />')
#2 {main}
  thrown in /usr/local/www/classes/Form/Input.class.php on line 127
[02-Sep-2023 11:58:46 Europe/Paris] PHP Fatal error:  Uncaught ValueError: Unknown format specifier "p" in /usr/local/www/classes/Form/Input.class.php:127
Stack trace:
#0 /usr/local/www/classes/Form/Input.class.php(127): sprintf('Nom de domaine ...', '<br />')
#1 /usr/local/www/services_dnsmasq_edit.php(85): Form_Input->setHelp('Domain of the h...', '<br />')
#2 {main}
  thrown in /usr/local/www/classes/Form/Input.class.php on line 127

I think it come from a french translation file because when i use original language, everithing works.

Files

PHP_errors (2).log (384 Bytes) PHP_errors (2).log aleksei prokofiev, 10/24/2025 11:36 AM

LP Updated by Lev Prokofev about 3 years ago Actions
Copy link
 #1

Can confirm that bug

Tested on

23.05.1-RELEASE (amd64)
built on Wed Jun 28 03:57:27 UTC 2023
FreeBSD 14.0-CURRENT

Steps to reproduce:
at System=>General setup switch language to French

Go to System=>DNS Forwarder

try to add a host override entry.

[02-Sep-2023 13:59:26 Europe/Moscow] PHP Fatal error:  Uncaught ValueError: Unknown format specifier "p" in /usr/local/www/classes/Form/Input.class.php:127
Stack trace:
#0 /usr/local/www/classes/Form/Input.class.php(127): sprintf('Nom de domaine ...', '<br />')
#1 /usr/local/www/services_dnsmasq_edit.php(85): Form_Input->setHelp('Domain of the h...', '<br />')
#2 {main}
  thrown in /usr/local/www/classes/Form/Input.class.php on line 127

JG Updated by Jordan G about 3 years ago Actions
Copy link
 #2

can confirm bug using above steps. spot checked various other languages and was unable to find this issue occurring on any other available language selections.

JP Updated by Jim Pingle about 3 years ago Actions
Copy link
 #3

  • Subject changed from Crash DNS Forwarder when add host to PHP error in DNS Forwarder host overrides when the language is set to French

AP Updated by aleksei prokofiev 11 months ago Actions
Copy link
 #4

Tested on
25.07.1-RELEASE (amd64)
built on Wed Aug 20 16:17:00 +04 2025
FreeBSD 15.0-CURRENT
Issue still persists

CM Updated by Christian McDonald 11 months ago Actions
Copy link
 #5

  • Status changed from New to In Progress
  • Assignee set to Christian McDonald
  • Target version set to 2.9.0
  • Plus Target Version set to 25.11

CM Updated by Christian McDonald 11 months ago Actions
Copy link
 #7

  • Status changed from In Progress to Feedback

CM Updated by Christian McDonald 11 months ago Actions
Copy link
 #8

  • % Done changed from 0 to 100

Applied in changeset commit:a8aa22049c73596ba1c74c160e73ab758f856457.

AP Updated by aleksei prokofiev 11 months ago Actions
Copy link
 #9

Applied patch in 25.07.1
Also tested on 25.11
25.11-BETA (amd64)
built on Mon Oct 6 9:00:00 MSK 2025
FreeBSD 15.0-PRERELEASE

The issue still persists

CM Updated by Christian McDonald 11 months ago Actions
Copy link
 #10

aleksei prokofiev wrote in #note-9:

Applied patch in 25.07.1
Also tested on 25.11
25.11-BETA (amd64)
built on Mon Oct 6 9:00:00 MSK 2025
FreeBSD 15.0-PRERELEASE

The issue still persists

This is a very old build. Please try latest build.

AP Updated by aleksei prokofiev 11 months ago Actions
Copy link
 #11

Re-tested on
25.11-BETA (amd64)
built on Tue Oct 28 18:38:00 UTC 2025
FreeBSD 16.0-CURRENT

Issue fixed

JP Updated by Jim Pingle 10 months ago Actions
Copy link
 #12

  • Status changed from Feedback to Closed
Actions
Copy link

Also available in: Atom