Feature #15221
open
Make System Tunables table sortable
100%
Description
On the System > Advanced page's System Tunables tab, it's really hard to
a) find/check values, since they are in no particular order
b) compare the settings of two machines, because, again, the values are in no particular order.
Being able to sort them by the Tunable Name is particularly important as it seems the Description of these fields has been changed over the years, so two systems originally set up at different times with different versions of pfSense have different descriptions for the same field, making it even harder to find/compare the values.
Files
Updated by GChuf 6 over 1 year ago
Created a PR here:
https://github.com/pfsense/pfsense/pull/4709
Updated by Jim Pingle 10 months ago
- Status changed from New to Pull Request Review
- Priority changed from High to Low
Updated by Jim Pingle 10 days ago
- Assignee set to Jim Pingle
- Target version set to 2.9.0
- Plus Target Version set to 26.03
Updated by GChuf 6 10 days ago
- Status changed from Pull Request Review to Feedback
- % Done changed from 0 to 100
Applied in changeset 004e84cf2efa84cfbe1884f62b822a2f59461f42.
Updated by Glenn Hall 3 days ago
I applied this patch and seem to have discovered an issue. With the patch in place, I am able to sort on any of the first three columns and that initially appears to work properly. However, it seems the fourth column (edit/delete) does not follow the sorting of the other columns and remains static. This means that when you attempt to edit one of the tunables after sorting, the edit fields that appear belong to a different tunable than the one you attempted to edit.
Updated by Jim Pingle 3 days ago
Glenn Hall wrote in #note-5:
I applied this patch and seem to have discovered an issue. With the patch in place, I am able to sort on any of the first three columns and that initially appears to work properly. However, it seems the fourth column (edit/delete) does not follow the sorting of the other columns and remains static. This means that when you attempt to edit one of the tunables after sorting, the edit fields that appear belong to a different tunable than the one you attempted to edit.
I can't reproduce this on dev snapshots here. The columns all sort properly, clicking edit on any item edits the expected item and so on. I tried sorting by all three columns (ascending and descending), and each time the action icons were correct.
Updated by Glenn Hall 2 days ago
- File sysctl-config-PFSENSE-A.home.arpa-20260129203910.xml sysctl-config-PFSENSE-A.home.arpa-20260129203910.xml added
I reverted the patch today and then loaded the latest available dev build which includes the patch natively (26.03.a.20260128.2142). I then did more testing and found that if I only have the default tunables in place, all sorting works correctly. However, I have added quite a few tunables and when all of them are loaded the sorting breaks in the manner I described previously. I have attached my System Tunables export so you can load them up and test. Hopefully, you are then able to reproduce the problem.
Updated by Jim Pingle 2 days ago
- Status changed from Feedback to In Progress
OK, I can reproduce the issue with that configuration. We'll keep working on it.
Updated by Jim Pingle 2 days ago
I just pushed a fix to ensure the tunables are always sorted the same way when editing, deleting, etc. It seems to have fixed this for me, but give it a try when it shows up (bc1322f22ff437a169fae932ce4c9e38286d49e7)
Updated by Jim Pingle 2 days ago
- Status changed from In Progress to Feedback
Applied in changeset bc1322f22ff437a169fae932ce4c9e38286d49e7.
Updated by Glenn Hall 1 day ago
I can confirm the latest patch fixes the issue I was seeing with the older patch and all sorting works properly now. Thank you!