Project

General

Profile

Actions

Bug #15734

open

Syslog priority levels shouldn't default to ERR

Added by Nic Bernstein 2 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Logging
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
All
Affected Architecture:
All

Description

Too much syslog output from pfSense is emitted as priority ERR when it's not. I believe this is due the the presence, in src/etc/inc/util.inc, of log_error(), but no similar functions for more nuanced reporting, such as log_warn, log_notice, log_info, or log_debug. Or just a parameterized generic log_message($message, $priority) function?

As an example, rc.filtersynchonize only emits ERR, even if the message is as benign as "Nothing has been configured to be synched. Skipping...."

Likewise, xmlrpc_client.inc makes five calls to log_error, even though two of these are the "Beginning XMLRPC sync..." and "XMLRPC reload data success ..."

There are just over 1200 calls to log_error in the codebase. How many of these are actually ERR level events?

Couldn't we get more finely grained logging? pfSense is a serious product, but the logging is so noisy as to be nearly useless.


Files

log_message.txt (1.53 KB) log_message.txt Example for priority adjustable log_message function Nic Bernstein, 09/19/2024 03:43 PM

No data to display

Actions

Also available in: Atom PDF