https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162011-07-07T22:01:25ZpfSense bugtrackerpfSense - Bug #1639: Port alias missing input validation in firewall_rules_edit.phphttps://redmine.pfsense.org/issues/1639?journal_id=63112011-07-07T22:01:25ZEvgeny Yurchenkoey@tm-k.com
<ul></ul><blockquote>
<p>A port alias can be assigned only as the "to" or "from" port, which is invalid and results in a pf syntax error.</p>
</blockquote>
<p>I did not manage to reproduce. If I put port alias only in from: and leave to: empty it is properly applied as if 'to=from'. If I put port alias only in to: leaving empty from: it is ignored and applied as 'to=from=any'.</p> pfSense - Bug #1639: Port alias missing input validation in firewall_rules_edit.phphttps://redmine.pfsense.org/issues/1639?journal_id=63122011-07-07T22:48:26ZEvgeny Yurchenkoey@tm-k.com
<ul></ul><p>Commit <a class="external" href="https://github.com/bsdperimeter/pfsense/commit/cfceda6d3528d4cdb87fccdb00f28ce194bf393f">https://github.com/bsdperimeter/pfsense/commit/cfceda6d3528d4cdb87fccdb00f28ce194bf393f</a></p> pfSense - Bug #1639: Port alias missing input validation in firewall_rules_edit.phphttps://redmine.pfsense.org/issues/1639?journal_id=63182011-07-08T08:12:37ZErmal Luçieri@pfsense.org
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li></ul> pfSense - Bug #1639: Port alias missing input validation in firewall_rules_edit.phphttps://redmine.pfsense.org/issues/1639?journal_id=63192011-07-08T08:14:18ZErmal Luçieri@pfsense.org
<ul></ul><p>Isnt this commit a bit drastic?<br />Possibly just check impossible combination should be enough?</p> pfSense - Bug #1639: Port alias missing input validation in firewall_rules_edit.phphttps://redmine.pfsense.org/issues/1639?journal_id=63202011-07-08T09:21:26ZEvgeny Yurchenkoey@tm-k.com
<ul></ul><p>Basically it checks for invalid combinations. I did not feel safe to call is_alias(something) without making sure 'something' is set. We can remove this things.</p> pfSense - Bug #1639: Port alias missing input validation in firewall_rules_edit.phphttps://redmine.pfsense.org/issues/1639?journal_id=66892011-08-13T23:07:32ZChris Buechlercbuechler@gmail.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul>