pfSense

The parsing of content from tgz archive URLs into URL table aliases is broken in several ways:

• It does not create a directory before trying to use it for tar output
• It is not reading the list of files to import from the directory where tar places the files
• It tries to write output to a file with the same name as the extraction directory, so creating the file fails
• It does not ensure the files in the archive are regular files before reading their content
• It tries to read with fread not fgets and ends up with an empty file as a result
• It does not clean up the directory where content was extracted when complete

Most of these bugs were not being hit because it failed earlier in the process, so they were moot, however, they all need to be fixed before functionality can be restored.

Reported by: @lujiefsi