Project

General

Profile

Bug #318

gzsig returning wrong exit code

Added by Chris Buechler over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Upgrade
Target version:
Start date:
01/22/2010
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

Auto-update currently isn't working with non-signed images because gzsig exits with the wrong exit code on unsigned images.

  1. gzsig verify /etc/pubkey.pem < latest.tgz
    No gzip signature found
    Couldn't verify input
  2. echo $?
    1

According to system_firmware_auto.php, it should (and used to) return 2 in such situations.

Associated revisions

Revision a0116247 (diff)
Added by Ermal Luçi about 9 years ago

Ticket #318. Add an option to updater settings to allow updates for images with no signature. This makes auto-updater work and will not display an confirmation message during manual update.

History

#1 Updated by Dan Swartzendruber over 9 years ago

I am very confused here. I have tracked all the way back to revision 1.1 in the original code and don't see where it ever returned anything other than 1. See this:

http://www.openssh.com/cgi-bin/cvsweb/src/usr.bin/gzsig/verify.c.diff?r1=text&tr1=1.1&r2=text&tr2=1.7

Maybe I am missing a key bit of dev info here that this was a pfsense enhancement? Or someone else's and a subsequent update to the port caused a regression?

#2 Updated by Ermal Luçi about 9 years ago

  • Status changed from New to Feedback

#4 Updated by Chris Buechler about 9 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF