Project

General

Profile

Actions

Bug #451

closed

[PATCH] DNS resolving is broken

Added by Henrik Kaare Poulsen about 15 years ago. Updated about 15 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Ermal Luçi
Category:
-
Target version:
-
Start date:
03/25/2010
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.0
Affected Architecture:

Description

DNS resolving is broken since https://rcs.pfsense.org/projects/pfsense/repos/mainline/commits/1033de7481dacd83ee5a1a16078e89c7b4e9efd8

Patch:


--- system.inc.ORIG    2010-03-25 16:22:15.000000000 +0000
+++ system.inc    2010-03-25 16:22:45.000000000 +0000
@@ -153,7 +153,7 @@
     if (is_array($dns_lists)) {
         foreach($dns_lists as $dns) {
             if(is_ipaddr($dns)) 
-                $master_list[] = $item;
+                $master_list[] = $dns;
         }
     }
Actions #1

Updated by Ermal Luçi about 15 years ago

  • Status changed from New to Closed
Actions #2

Updated by Henrik Kaare Poulsen about 15 years ago

I am very sorry if I have broken some unwritten rules, or have not yet found the written rules.
I am new to pfSense, but an OpenSource developer myself, so please accept my apologies.

(1) As I knew you where working on the issue, I assigned the ticket to you. Sorry about the mistake. In the future I shall not assign tickets to anyone.

(2) I do not understand the "check well before reporting" comment.
I have installed 20100324-0246 and upgraded to 20100324-2048 from console.
In this setup I experience the problem, and the patch fixes the problem for me.

When trying to access Gitorious, I get "We're sorry, but something went wrong. We've been notified about this issue and we'll take a look at it shortly.", so it is a bit difficult to see if the problem has been fixed already...

Again: I am very sorry if I am doing things in the wrong way. I am not a troll, and I will do my best to abide by the rules as soon as I am aware of them.

Actions

Also available in: Atom PDF