https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162015-05-26T00:41:39ZpfSense bugtrackerpfSense - Feature #4683: Support for elliptic curve for IPsec on webconfiguratorhttps://redmine.pfsense.org/issues/4683?journal_id=185232015-05-26T00:41:39ZLars Pedersenthacaleb@gmail.com
<ul></ul><p>Can be closed: Solved with <a class="external" href="https://github.com/pfsense/pfsense/pull/1649">https://github.com/pfsense/pfsense/pull/1649</a></p> pfSense - Feature #4683: Support for elliptic curve for IPsec on webconfiguratorhttps://redmine.pfsense.org/issues/4683?journal_id=185272015-05-26T11:39:10ZChris Buechlercbuechler@gmail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>Assignee</strong> set to <i>Chris Buechler</i></li><li><strong>Target version</strong> set to <i>2.2.3</i></li></ul> pfSense - Feature #4683: Support for elliptic curve for IPsec on webconfiguratorhttps://redmine.pfsense.org/issues/4683?journal_id=187642015-06-11T17:06:32ZChris Buechlercbuechler@gmail.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>confirmed. Thanks!</p> pfSense - Feature #4683: Support for elliptic curve for IPsec on webconfiguratorhttps://redmine.pfsense.org/issues/4683?journal_id=188052015-06-15T04:04:16ZLars Pedersenthacaleb@gmail.com
<ul></ul><p>Chris Buechler wrote:</p>
<blockquote>
<p>confirmed. Thanks!</p>
</blockquote>
<p>Can see that you have set the target version to 2.2.3. Will you cherry pick this patch to RELENG_2_2?</p> pfSense - Feature #4683: Support for elliptic curve for IPsec on webconfiguratorhttps://redmine.pfsense.org/issues/4683?journal_id=188112015-06-15T09:52:18ZErmal Luçieri@pfsense.org
<ul></ul><p>It is already in 2.2.3 since the merge.<br />I merged it manually.</p> pfSense - Feature #4683: Support for elliptic curve for IPsec on webconfiguratorhttps://redmine.pfsense.org/issues/4683?journal_id=188182015-06-16T01:39:11ZLars Pedersenthacaleb@gmail.com
<ul></ul><p>Ermal Luçi wrote:</p>
<blockquote>
<p>It is already in 2.2.3 since the merge.<br />I merged it manually.</p>
</blockquote>
<p>I'm still not convinced that it has been merged since ”brainpool” is nowhere to be found in:<br /><a class="external" href="https://github.com/pfsense/pfsense/blob/RELENG_2_2/etc/inc/ipsec.inc">https://github.com/pfsense/pfsense/blob/RELENG_2_2/etc/inc/ipsec.inc</a></p>
<p>Besides the ipsec.inc file last update was 2 months ago.</p> pfSense - Feature #4683: Support for elliptic curve for IPsec on webconfiguratorhttps://redmine.pfsense.org/issues/4683?journal_id=188972015-06-19T05:44:02ZErmal Luçieri@pfsense.org
<ul></ul><p>Merged.</p> pfSense - Feature #4683: Support for elliptic curve for IPsec on webconfiguratorhttps://redmine.pfsense.org/issues/4683?journal_id=189332015-06-22T08:21:54ZLars Pedersenthacaleb@gmail.com
<ul></ul><p>Can see that you have only merged parts of the 1649 pull request. Things like IPsec phase 1 is missing AES GCM support and the function vpn_ipsec_convert_to_modp has not been updated too. So the current snapshot is broken with the new functionalities.</p>
<p>So will you be kind to do a fully merge of the given pull request :)</p> pfSense - Feature #4683: Support for elliptic curve for IPsec on webconfiguratorhttps://redmine.pfsense.org/issues/4683?journal_id=189372015-06-22T13:32:29ZChris Buechlercbuechler@gmail.com
<ul><li><strong>Target version</strong> changed from <i>2.2.3</i> to <i>2.3</i></li></ul><p>Thanks for the heads up, Lars. We're short on time for 2.2.3, plus don't generally put features into maintenance releases, so I reverted the partial incorrect merge. 2.3 isn't too far into the future.</p>