https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162015-05-08T18:19:15ZpfSense bugtrackerpfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=183602015-05-08T18:19:15ZBen Cook
<ul></ul><p>Perhaps it is obvious, but it looks like the calls to "<code>codel_alloc(100, 5, 0);</code>" in one/all of the "altq_codel.diff" need to change to "<code>codel_alloc(5, 100, 0);</code>".</p> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=183612015-05-08T19:50:54ZBen Cook
<ul><li><strong>File</strong> <a href="/attachments/1241">codel_opts_value_fix.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1241/codel_opts_value_fix.patch">codel_opts_value_fix.patch</a> added</li></ul><p>My apologies if this patch is incorrect or causes a fire. I figured I would try. It modifies pfsense-tools/patches/stable/10/altq_codel.diff to fix 4 uses of "codel_alloc" to the more optimal target/interval values.</p> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=193482015-07-21T11:45:35ZRenato Botelhorenato@netgate.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>Assignee</strong> changed from <i>Ermal Luçi</i> to <i>Renato Botelho</i></li><li><strong>Target version</strong> set to <i>2.2.4</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Pull request has been merged. Thanks!</p> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=193492015-07-21T18:48:38ZBen Cook
<ul></ul><p>I think there is already a (newer) patch merged, but according to a few sources, the patch is not working.</p>
<p><a class="external" href="https://github.com/pfsense/pfsense-tools/commit/3108a902bd816036a3abffd3ec669767140891a7">https://github.com/pfsense/pfsense-tools/commit/3108a902bd816036a3abffd3ec669767140891a7</a></p>
<p>Revert it until someone can do a proper fix?</p>
<p>My assumption that this bug was so simple to fix that I could forgoe building pfSense to confirm the patch's functionality was plain stupid. No more code submissions from me until I can build pfSense reliably.</p> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=193502015-07-21T18:56:53ZRenato Botelhorenato@netgate.com
<ul></ul><p>Ben Cook wrote:</p>
<blockquote>
<p>I think there is already a (newer) patch merged, but according to a few sources, the patch is not working.</p>
<p><a class="external" href="https://github.com/pfsense/pfsense-tools/commit/3108a902bd816036a3abffd3ec669767140891a7">https://github.com/pfsense/pfsense-tools/commit/3108a902bd816036a3abffd3ec669767140891a7</a></p>
<p>Revert it until someone can do a proper fix?</p>
<p>My assumption that this bug was so simple to fix that I could forgoe building pfSense to confirm the patch's functionality was plain stupid. No more code submissions from me until I can build pfSense reliably.</p>
</blockquote>
<p>Which patch you say is not working? commit:3108a902bd or the one you submitted?</p>
<p>Did you try a recent 2.2.4 snapshot? Did you get same problem?</p> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=193512015-07-21T19:10:54ZBen Cook
<ul></ul><p>Renato Botelho wrote:</p>
<blockquote>
<p>Ben Cook wrote:</p>
<blockquote>
<p>I think there is already a (newer) patch merged, but according to a few sources, the patch is not working.</p>
<p><a class="external" href="https://github.com/pfsense/pfsense-tools/commit/3108a902bd816036a3abffd3ec669767140891a7">https://github.com/pfsense/pfsense-tools/commit/3108a902bd816036a3abffd3ec669767140891a7</a></p>
<p>Revert it until someone can do a proper fix?</p>
<p>My assumption that this bug was so simple to fix that I could forgoe building pfSense to confirm the patch's functionality was plain stupid. No more code submissions from me until I can build pfSense reliably.</p>
</blockquote>
<p>Which patch you say is not working? commit:3108a902bd or the one you submitted?</p>
<p>Did you try a recent 2.2.4 snapshot? Did you get same problem?</p>
</blockquote>
<p>commit:3108a902bd is mine from github, I think.</p>
<p>I will try out a snapshot.</p> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=193612015-07-22T04:47:54ZKieran Cawthraykieranc@gmail.com
<ul></ul><p>As far as I can see, the interval is correctly set to 100 on both the 20150721 and 20150719 nightly builds, the target can be set using 'queue limit'.</p> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=193622015-07-22T05:14:20ZKieran Cawthraykieranc@gmail.com
<ul></ul><p>Kieran Cawthray wrote:</p>
<blockquote>
<p>As far as I can see, the interval is correctly set to 100 on both the 20150721 and 20150719 nightly builds, the target can be set using 'queue limit'.</p>
</blockquote>
<p>I just checked 20150708 nightly and the interval is 100. I also tested 2.2.3 release and got an interval of 5, so it was fixed somewhere between 20150625 and 20150708, probably commit 3108a902bd816036a3abffd3ec669767140891a7 on 20150629?</p> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=193632015-07-22T05:31:55ZBen Cook
<ul></ul><p>Good to hear.</p>
<p>There are two different methods of employing codel.</p>
<p>1. Where codel is the one and only scheduling discipline for a single parent queue with no other sub-queues.</p>
<p>2. Where codel is a sub-discipline ("Codel Active Queue" check-box) under one of the primary schedulers (HFSC, CBQ, PRIQ, FAIRQ).</p>
<p>The pfctl command in my original post will show the values of codel in a method-1 situation, but does anyone know how to display codel's configuration values when codel is a sub-discipline of another scheduler like in method-2?</p> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=193672015-07-22T07:46:31ZRenato Botelhorenato@netgate.com
<ul><li><strong>Assignee</strong> changed from <i>Renato Botelho</i> to <i>Luiz Souza</i></li></ul> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=193782015-07-22T15:21:02ZRenato Botelhorenato@netgate.com
<ul><li><strong>Target version</strong> changed from <i>2.2.4</i> to <i>2.3</i></li></ul><p>Codel patch is being reviewed</p> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=222892015-11-11T14:36:52ZLuiz Souzaluiz@netgate.com
<ul></ul><p>The codel code (reviewed and) committed in FreeBSD is now backported to 2.3.</p> pfSense - Bug #4692: CODELQ scheduler defaults to incorrect "target" and "interval" values.https://redmine.pfsense.org/issues/4692?journal_id=241252016-01-15T03:41:51ZRenato Botelhorenato@netgate.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>Fixed</p>