https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162015-07-11T21:57:15ZpfSense bugtrackerpfSense - Bug #4830: "Interface" selected in GUI for L2TP server are not respected in mpd's confighttps://redmine.pfsense.org/issues/4830?journal_id=191222015-07-11T21:57:15ZPhillip Davisphil@jankaritech.com
<ul></ul><p>The interface gets saved OK in the config, but in /etc/inc.vpn.inc function vpn_l2tp_configure() there is no mention of 'interface'. It seems to me that there is simply no code to implement the selected interface - seems odd, but would explain why selecting a particular interface has no effect.</p> pfSense - Bug #4830: "Interface" selected in GUI for L2TP server are not respected in mpd's confighttps://redmine.pfsense.org/issues/4830?journal_id=191252015-07-12T01:12:47ZTaras Savchuktaras@1adm.ru
<ul></ul><p>Works for me.</p>
<p><code>[2.2.2-RELEASE][admin@gw.localdomain]/etc/inc: diff vpn.inc vpn.inc.orig<br />1650,1654d1649<br />< $l2tp_listen="";<br />< $ipaddr = get_interface_ip(get_failover_interface($l2tpcfg['interface']));<br />< if (is_ipaddrv4($ipaddr))<br />< $l2tp_listen="set l2tp self $ipaddr";<br /><<br />1712d1706<br />< {$l2tp_listen}<br /></code></p>
<p>P.S. Don't know is it necessary to check IP with is_ipaddrv4().</p> pfSense - Bug #4830: "Interface" selected in GUI for L2TP server are not respected in mpd's confighttps://redmine.pfsense.org/issues/4830?journal_id=191262015-07-12T01:18:41ZTaras Savchuktaras@1adm.ru
<ul><li><strong>File</strong> <a href="/attachments/1298">vpn.inc.diff.txt</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1298/vpn.inc.diff.txt">vpn.inc.diff.txt</a> added</li></ul><p>Diff attached.</p> pfSense - Bug #4830: "Interface" selected in GUI for L2TP server are not respected in mpd's confighttps://redmine.pfsense.org/issues/4830?journal_id=191772015-07-13T07:05:10ZTaras Savchuktaras@1adm.ru
<ul></ul><p>Can it be included into 2.2.4?</p> pfSense - Bug #4830: "Interface" selected in GUI for L2TP server are not respected in mpd's confighttps://redmine.pfsense.org/issues/4830?journal_id=191782015-07-13T07:34:45ZPhillip Davisphil@jankaritech.com
<ul></ul><p>It will be easy for the devs to review if you go to <a class="external" href="https://github.com/pfsense/pfsense">https://github.com/pfsense/pfsense</a> and make the edit yourself and submit a pull request. It can all be done online easily.</p> pfSense - Bug #4830: "Interface" selected in GUI for L2TP server are not respected in mpd's confighttps://redmine.pfsense.org/issues/4830?journal_id=191792015-07-13T07:52:39ZTaras Savchuktaras@1adm.ru
<ul></ul><p>Thanks Phillip!</p>
<p>Done.</p> pfSense - Bug #4830: "Interface" selected in GUI for L2TP server are not respected in mpd's confighttps://redmine.pfsense.org/issues/4830?journal_id=209352015-09-20T03:52:59ZKill Bill
<ul></ul><p>Resubmitted as:<br /><a class="external" href="https://github.com/pfsense/pfsense/pull/1911">https://github.com/pfsense/pfsense/pull/1911</a> - RELENG_2_2<br /><a class="external" href="https://github.com/pfsense/pfsense/pull/1912">https://github.com/pfsense/pfsense/pull/1912</a> - master</p> pfSense - Bug #4830: "Interface" selected in GUI for L2TP server are not respected in mpd's confighttps://redmine.pfsense.org/issues/4830?journal_id=210322015-09-21T14:50:31ZRenato Botelhorenato@netgate.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>Priority</strong> changed from <i>High</i> to <i>Normal</i></li><li><strong>Target version</strong> set to <i>2.2.5</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Pull request has been merged and cherry-picked to RELENG_2_2</p> pfSense - Bug #4830: "Interface" selected in GUI for L2TP server are not respected in mpd's confighttps://redmine.pfsense.org/issues/4830?journal_id=211852015-09-25T17:24:56ZChris Buechlercbuechler@gmail.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li><li><strong>Affected Version</strong> changed from <i>2.2.2</i> to <i>All</i></li></ul><p>fixed, thanks!</p>