https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162015-11-10T17:31:58ZpfSense bugtrackerBootstrap - Bug #5400: diag_ping.php - Following link to pre-fill page results in an incorrect errorhttps://redmine.pfsense.org/issues/5400?journal_id=221802015-11-10T17:31:58Zjeroen van breedamhepnix@gmail.com
<ul></ul><p>proposed fix:<br /><a class="external" href="https://github.com/pfsense/pfsense/pull/2055">https://github.com/pfsense/pfsense/pull/2055</a></p> Bootstrap - Bug #5400: diag_ping.php - Following link to pre-fill page results in an incorrect errorhttps://redmine.pfsense.org/issues/5400?journal_id=221822015-11-10T17:40:35ZAnonymous
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Feedback</i></li><li><strong>Assignee</strong> changed from <i>Anonymous</i> to <i>Jim Pingle</i></li></ul><p>Fixed by heper:patch-2 PR: 1932 now merged.</p> Bootstrap - Bug #5400: diag_ping.php - Following link to pre-fill page results in an incorrect errorhttps://redmine.pfsense.org/issues/5400?journal_id=222632015-11-11T08:55:13ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Confirmed</i></li><li><strong>Assignee</strong> changed from <i>Jim Pingle</i> to <i>Anonymous</i></li></ul><p>This shouldn't be taking the action on following the link, it should only be pre-filling the form. Automatically taking an action like that on GET isn't desirable.</p> Bootstrap - Bug #5400: diag_ping.php - Following link to pre-fill page results in an incorrect errorhttps://redmine.pfsense.org/issues/5400?journal_id=222642015-11-11T09:08:19ZJim Pingle
<ul><li><strong>Assignee</strong> changed from <i>Anonymous</i> to <i>Jim Pingle</i></li></ul><p>I'll take this, looks like there is a similar problem with traceroute, I've got a fix.</p> Bootstrap - Bug #5400: diag_ping.php - Following link to pre-fill page results in an incorrect errorhttps://redmine.pfsense.org/issues/5400?journal_id=222652015-11-11T09:20:11ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Feedback</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="For Diag > Ping and Diag > Traceroute, only perform the action on POST, not by following a link/G..." href="https://redmine.pfsense.org/projects/pfsense/repository/2/revisions/ed69a49666fa5f7e9fe1366d9f176ffba15536f1">pfsense:ed69a49666fa5f7e9fe1366d9f176ffba15536f1</a>.</p> Bootstrap - Bug #5400: diag_ping.php - Following link to pre-fill page results in an incorrect errorhttps://redmine.pfsense.org/issues/5400?journal_id=223502015-11-12T11:33:44ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>Looks good here, it's behaving as expected now. No errors on load and it does not take action until the form is submitted.</p>