Project

General

Profile

Bug #5484

diag_routes.php not displaying the full interface name

Added by Alexandre Paradis over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Low
Category:
Operating System
Target version:
Start date:
11/19/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

Under ipv4, netif

I have igb1_vlan3, but the real interface is igb1_vlan36.

the 6 is missing.

Destination Gateway Flags Use Mtu Netif Expire
default 10.11.16.241 UGS 230002453 1458 pppoe2
10.0.0.0/8 10.241.48.1 UGS 164474 1500 igb1_vlan3

Associated revisions

Revision d52a7eb8 (diff)
Added by Renato Botelho over 3 years ago

Add -W to netstat call to make sure long interface name will be not truncated. Ticket #5484

History

#1 Updated by Phillip Davis over 3 years ago

This a "wonderful" feature of the netstat utility. The underlying code does this command to gather the data:
/usr/bin/netstat -rW -f inet

The "W" is supposed to make the display wide (and thus not cut off the characters in any fields). But it still limits the text length of the Netif field!
https://lists.freebsd.org/pipermail/freebsd-bugs/2014-April/055732.html
https://www.mail-archive.com/freebsd-bugs@freebsd.org/msg07205.html

That is rubbish. Can someone fix that on FreeBSD? Or add a "WW" option that does "really do not truncate any output fields".

#2 Updated by Jim Pingle over 3 years ago

This was fixed recently in FreeBSD HEAD,

https://svnweb.freebsd.org/base?view=revision&revision=290367

Not sure if that had an MFC (searching doesn't turn one up)

#3 Updated by Phillip Davis over 3 years ago

Seems a good thing to get MFC'd back to 10-STABLE - it makes the output do what most people are hoping it would do anyway. Admittedly it could break someones (dumb) script that expects the -W output to have fixed-width (but wider than ordinary) columns. But the doc of -W implies that the output could be any width. Nobody should be depending on fixed-width columns when using -W

Anyway, I guess ESF knows how to start the MFC process. It seems an easy little bit of crud to fix.

#4 Updated by Jim Thompson over 3 years ago

I've sent email to ume@ asking for a MFC.

#5 Updated by Chris Buechler over 3 years ago

  • Subject changed from https://192.168.1.1/diag_routes.php not displaying the full interface name to diag_routes.php not displaying the full interface name
  • Status changed from New to Confirmed
  • Affected Version changed from 2.2.5 to All

#6 Updated by Renato Botelho over 3 years ago

  • Category changed from Web Interface to Operating System
  • Status changed from Confirmed to Feedback
  • Assignee set to Renato Botelho
  • Target version set to 2.3
  • % Done changed from 0 to 100

ume@ said he is going to MFC changes, and he also sent us the stable/10 patch. It was applied at

https://github.com/pfsense/FreeBSD-src/commit/99ddd03d08b1fd5ae8f8ba04cac699afbe3ffb24

#7 Updated by Chris Buechler over 3 years ago

this actually working for anyone? Building world on a stock 11-CURRENT now to check it. VLANs on lagg for instance still come up cut off to 10 characters in 'netstat -rW -f inet'. lagg0_vlanXX ends up as 'lagg0_vlan'.

#8 Updated by Phillip Davis over 3 years ago

That patch fixes the interface name field output for:
/usr/bin/netstat -i -f inet
Name Mtu Network Address Ipkts Ierrs Idrop Opkts Oerrs Coll
re0 - 10.49.68.0/22 10.49.68.250 0 - - 0 - -
re1 - 10.49.208.0/2 10.49.209.3 119101 - - 3176 - -
...
re0_vlan901 - 172.16.0.0 172.16.0.1 0 - - 0 - -

But not for:
/usr/bin/netstat -rW -f inet
Routing tables

Internet:
Destination Gateway Flags Use Mtu Netif Expire
...
172.16.0.0 link#13 U 0 1500 re0_vlan90
172.16.0.1 link#13 UHS 0 16384 lo0

There needs to be something similar for the Netif column in different code.

#9 Updated by Renato Botelho over 3 years ago

  • Status changed from Feedback to New

This was fixed on FreeBSD HEAD on Nov 20, after following commit:

https://svnweb.freebsd.org/base?view=revision&revision=291097

This is marked to be MFC'd to stable/10 in 1 week. After it's MFC'd I'll merge stable/10 to our devel branch and this ticket will be fixed. Moving it to new for now

#10 Updated by Renato Botelho over 3 years ago

  • Status changed from New to Feedback

Merged in r291381, and merged back to pfSense/FreeBSD-src repo.

Next round of snapshots should be fixed.

#11 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved

fixed

Also available in: Atom PDF