https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162016-02-21T06:49:19ZpfSense bugtrackerpfSense - Bug #5916: General Setup page cannot be saved with blank DNS server slotshttps://redmine.pfsense.org/issues/5916?journal_id=253682016-02-21T06:49:19ZPhillip Davisphil@jankaritech.com
<ul></ul><p>This helps: <a class="external" href="https://github.com/pfsense/pfsense/pull/2680">https://github.com/pfsense/pfsense/pull/2680</a></p> pfSense - Bug #5916: General Setup page cannot be saved with blank DNS server slotshttps://redmine.pfsense.org/issues/5916?journal_id=253692016-02-21T06:52:27ZPhillip Davisphil@jankaritech.com
<ul></ul><p>Now I see that there is an alternative solution already in pull request <a class="external" href="https://github.com/pfsense/pfsense/pull/2678">https://github.com/pfsense/pfsense/pull/2678</a><br />Take your pick.</p> pfSense - Bug #5916: General Setup page cannot be saved with blank DNS server slotshttps://redmine.pfsense.org/issues/5916?journal_id=253702016-02-21T07:40:23ZPhillip Davisphil@jankaritech.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="Fix #5916 Do not complain about duplicated blank DNS server entries Reported by redmine https://..." href="https://redmine.pfsense.org/projects/pfsense/repository/2/revisions/bdfe939c4e1d30ba0d10bd6b9e995f1129bb483e">bdfe939c4e1d30ba0d10bd6b9e995f1129bb483e</a>.</p> pfSense - Bug #5916: General Setup page cannot be saved with blank DNS server slotshttps://redmine.pfsense.org/issues/5916?journal_id=253712016-02-21T07:50:55ZAnonymous
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>No harm in applying both.</p> pfSense - Bug #5916: General Setup page cannot be saved with blank DNS server slotshttps://redmine.pfsense.org/issues/5916?journal_id=253722016-02-21T07:51:18ZAnonymous
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li><li><strong>Assignee</strong> set to <i>Mark Furneaux</i></li></ul> pfSense - Bug #5916: General Setup page cannot be saved with blank DNS server slotshttps://redmine.pfsense.org/issues/5916?journal_id=253762016-02-21T21:09:02ZMark Furneauxmarkfurneaux@gmail.com
<ul></ul><p>Actually there is harm in both. The change in <a class="external" href="https://github.com/pfsense/pfsense/pull/2680">https://github.com/pfsense/pfsense/pull/2680</a> will cause a crash if all DNS server slots are empty when array_filter() is called. One of the two patches needs to be reverted.</p> pfSense - Bug #5916: General Setup page cannot be saved with blank DNS server slotshttps://redmine.pfsense.org/issues/5916?journal_id=253772016-02-21T21:22:32ZMark Furneauxmarkfurneaux@gmail.com
<ul></ul><p>On a second look, 2680 will always crash when no servers are populated, so it is the one which must be reverted.</p> pfSense - Bug #5916: General Setup page cannot be saved with blank DNS server slotshttps://redmine.pfsense.org/issues/5916?journal_id=253832016-02-22T08:54:26ZAnonymous
<ul></ul><p>2680 reverted.</p> pfSense - Bug #5916: General Setup page cannot be saved with blank DNS server slotshttps://redmine.pfsense.org/issues/5916?journal_id=254402016-02-26T20:40:19ZMark Furneauxmarkfurneaux@gmail.com
<ul></ul><p>Tested in 2.3.b.20160226.1008 and everything looks good. I think this can be closed.</p> pfSense - Bug #5916: General Setup page cannot be saved with blank DNS server slotshttps://redmine.pfsense.org/issues/5916?journal_id=254412016-02-26T20:45:11ZChris Buechlercbuechler@gmail.com
<ul><li><strong>Category</strong> set to <i>Web Interface</i></li><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li><li><strong>Target version</strong> set to <i>2.3</i></li></ul><p>yeah this is all good, thanks! pointy hat to me for not thinking of this use case</p>