https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162016-03-14T17:52:52ZpfSense bugtrackerpfSense - Todo #5994: Make Advanced Buttons work consistentlyhttps://redmine.pfsense.org/issues/5994?journal_id=257042016-03-14T17:52:52ZPhillip Davisphil@jankaritech.com
<ul></ul><p>I can look at this tonight (my time) = Tuesday day US time.</p> pfSense - Todo #5994: Make Advanced Buttons work consistentlyhttps://redmine.pfsense.org/issues/5994?journal_id=257122016-03-15T10:23:00ZPhillip Davisphil@jankaritech.com
<ul></ul><p>Done so far:<br />services_dhcp.php - <a class="external" href="https://github.com/pfsense/pfsense/commit/afe62c2bbb892f053c8264f3c2bffa6a15111990">https://github.com/pfsense/pfsense/commit/afe62c2bbb892f053c8264f3c2bffa6a15111990</a><br />services_dhcp_edit.php - <a class="external" href="https://github.com/pfsense/pfsense/commit/7a2c01319093262a09099def402bf00cab3b5c3c">https://github.com/pfsense/pfsense/commit/7a2c01319093262a09099def402bf00cab3b5c3c</a><br />services_dhcpv6.php - <a class="external" href="https://github.com/pfsense/pfsense/commit/4aa42b06a6cd64e93d7b0a243bcb82d8b741efa2">https://github.com/pfsense/pfsense/commit/4aa42b06a6cd64e93d7b0a243bcb82d8b741efa2</a></p>
<p>system_gateways_edit.php - pull request <a class="external" href="https://github.com/pfsense/pfsense/pull/2742">https://github.com/pfsense/pfsense/pull/2742</a></p>
<p>To be done:<br />services_ntpd.php<br />services_ntpd_gps.php<br />services_unbound.php (Custom Options button)<br />interfaces_bridge_edit.php<br />interfaces_ppps_edit.php<br />firewall_rules_edit.php<br />firewall_nat_edit.php</p>
<p>Look at pkg_edit.php - it has some support for "Advanced Options" - and see if there is anything useful to be done there.</p>
<p>About 40% complete.</p> pfSense - Todo #5994: Make Advanced Buttons work consistentlyhttps://redmine.pfsense.org/issues/5994?journal_id=257442016-03-17T08:12:22ZPhillip Davisphil@jankaritech.com
<ul></ul><p>These have also now been done and committed:<br />services_ntpd.php - <a class="external" href="https://github.com/pfsense/pfsense/commit/c0d1ceda2ced97fc9aefff5363b995c2103abd8c">https://github.com/pfsense/pfsense/commit/c0d1ceda2ced97fc9aefff5363b995c2103abd8c</a><br />services_ntpd_gps.php - <a class="external" href="https://github.com/pfsense/pfsense/commit/bd9fe79557a161d6c0e6b37791d7a51f7ddc8ba0">https://github.com/pfsense/pfsense/commit/bd9fe79557a161d6c0e6b37791d7a51f7ddc8ba0</a><br />interfaces_bridge_edit.php - <a class="external" href="https://github.com/pfsense/pfsense/commit/6dfeb992d94653b1bbe079a4089d53148c9a4bc5">https://github.com/pfsense/pfsense/commit/6dfeb992d94653b1bbe079a4089d53148c9a4bc5</a><br />interfaces_ppps_edit.php <a class="external" href="https://github.com/pfsense/pfsense/commit/b29b3831ba2bc281f5711b252fc93d2ebdcb0e07">https://github.com/pfsense/pfsense/commit/b29b3831ba2bc281f5711b252fc93d2ebdcb0e07</a></p>
<p>These have pull requests waiting for review:<br />firewall_rules_edit.php - <a class="external" href="https://github.com/pfsense/pfsense/pull/2754">https://github.com/pfsense/pfsense/pull/2754</a><br />firewall_nat_edit.php - <a class="external" href="https://github.com/pfsense/pfsense/pull/2758">https://github.com/pfsense/pfsense/pull/2758</a></p>
<p>To be done:<br />services_unbound.php (Custom Options button)</p>
<p>90% complete</p> pfSense - Todo #5994: Make Advanced Buttons work consistentlyhttps://redmine.pfsense.org/issues/5994?journal_id=257452016-03-17T08:55:38ZPhillip Davisphil@jankaritech.com
<ul></ul><p>All now done and committed:<br />firewall_rules_edit.php - <a class="external" href="https://github.com/pfsense/pfsense/commit/c3ed121066c5ec2c201bc06a4b5e0db321842d01">https://github.com/pfsense/pfsense/commit/c3ed121066c5ec2c201bc06a4b5e0db321842d01</a><br />firewall_nat_edit.php - <a class="external" href="https://github.com/pfsense/pfsense/commit/61aa0edbe5c815b5fb43571206cc3761f2497361">https://github.com/pfsense/pfsense/commit/61aa0edbe5c815b5fb43571206cc3761f2497361</a><br />services_unbound.php - <a class="external" href="https://github.com/pfsense/pfsense/commit/2c95f1cd20ecb074a7d30ada37a70e22ead85fbd">https://github.com/pfsense/pfsense/commit/2c95f1cd20ecb074a7d30ada37a70e22ead85fbd</a></p>
<p>100% complete from me. Please review, test and (hopefully) update status to resolved.</p> pfSense - Todo #5994: Make Advanced Buttons work consistentlyhttps://redmine.pfsense.org/issues/5994?journal_id=257462016-03-17T09:22:10ZRenato Botelhorenato@netgate.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Thank you Phil!</p> pfSense - Todo #5994: Make Advanced Buttons work consistentlyhttps://redmine.pfsense.org/issues/5994?journal_id=257492016-03-17T09:37:10ZJim Pingle
<ul><li><strong>Assignee</strong> set to <i>Jim Pingle</i></li></ul><p>to me for testing</p> pfSense - Todo #5994: Make Advanced Buttons work consistentlyhttps://redmine.pfsense.org/issues/5994?journal_id=257502016-03-17T09:43:38ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Assigned</i></li><li><strong>Assignee</strong> changed from <i>Jim Pingle</i> to <i>Phillip Davis</i></li></ul><p>They all look OK except for firewall_rules_edit.php -- When creating a brand new rule, which defaults to TCP, it shows "Hide Advanced" but the block is already hidden. Clicking it switches the button to "Display advanced" and then clicking expands as expected. If you don't click anything and instead change it to another protocol with ports like UDP or TCP/UDP, the source ports show.</p>
<p>Doesn't quite sound the same as <a class="issue tracker-1 status-3 priority-4 priority-default closed" title="Bug: JavaScript error in firewall_nat_edit.php for protocols that do not use ports (Resolved)" href="https://redmine.pfsense.org/issues/6007">#6007</a> but it doesn't surprise me that there are some lingering issues with JS on that page, it's pretty complicated especially with its many possible initial states + changes.</p> pfSense - Todo #5994: Make Advanced Buttons work consistentlyhttps://redmine.pfsense.org/issues/5994?journal_id=257602016-03-17T16:46:47ZPhillip Davisphil@jankaritech.com
<ul></ul><p>It needed to fix the test for if a source port from/to fields were default or not, so it considers blank or "any" to both be valid default values.<br /><a class="external" href="https://github.com/pfsense/pfsense/pull/2760">https://github.com/pfsense/pfsense/pull/2760</a></p> pfSense - Todo #5994: Make Advanced Buttons work consistentlyhttps://redmine.pfsense.org/issues/5994?journal_id=257632016-03-17T17:12:27ZPhillip Davisphil@jankaritech.com
<ul></ul><p>Also since <a class="issue tracker-1 status-3 priority-4 priority-default closed" title="Bug: interfaces_ppps_edit periodic reset settings not saved (Resolved)" href="https://redmine.pfsense.org/issues/6003">#6003</a> is fixed so that the periodic reset radio button setting is saved in interfaces_pps_edit.php <a class="issue tracker-1 status-3 priority-4 priority-default closed" title="Bug: interfaces_ppps_edit periodic reset settings not saved (Resolved)" href="https://redmine.pfsense.org/issues/6003">#6003</a>, I noticed that the Advanced fields did not open on page load for that case.<br />Test criteria fixed to include that, pull request: <a class="external" href="https://github.com/pfsense/pfsense/pull/2762">https://github.com/pfsense/pfsense/pull/2762</a></p>
<p>That should be all for issue <a class="issue tracker-4 status-3 priority-4 priority-default closed" title="Todo: Make Advanced Buttons work consistently (Resolved)" href="https://redmine.pfsense.org/issues/5994">#5994</a></p> pfSense - Todo #5994: Make Advanced Buttons work consistentlyhttps://redmine.pfsense.org/issues/5994?journal_id=257732016-03-18T14:57:12ZRenato Botelhorenato@netgate.com
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Feedback</i></li></ul><p>Both PRs had been merged. Thanks!</p> pfSense - Todo #5994: Make Advanced Buttons work consistentlyhttps://redmine.pfsense.org/issues/5994?journal_id=257742016-03-18T15:00:24ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>The rules case seems to be better after that, looks like this can be closed out.</p>