Project

General

Profile

Bug #6050

services_dhcp.php: "Network booting" section default style is confusing/easy to overlook

Added by Jim Pingle over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
DHCP Server
Target version:
Start date:
03/31/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3.x
Affected Architecture:

Description

On services_dhcp.php the "Network Booting" options are in their own separate section which defaults to collapsed. Unlike the other areas on the page that have their options hidden behind an "Display Advanced" type button, the Network Booting section has to be manually expanded using the button in the section header.

Perhaps it could stay its own section but have its options hidden using a button similar to the other areas of the page for consistency.

Associated revisions

Revision 68de2169 (diff)
Added by Phillip Davis over 3 years ago

Fix #6050 DHCP - provide Network Booting display/hide advanced button

This one moves the "Network Booting" above the "Additional BOOTP/DHCP Options". That allows "Network Booting" to be a Display/Hide Advanced group of buttons just like TFTP, LDAP etc. (without a special section header) and for "Additional BOOTP/DHCP Options" to come last on the page.

Revision c323224d (diff)
Added by Phillip Davis over 3 years ago

Fix #6050 DHCP - provide Network Booting display/hide advanced button

This one moves the "Network Booting" above the "Additional BOOTP/DHCP Options". That allows "Network Booting" to be a Display/Hide Advanced group of buttons just like TFTP, LDAP etc. (without a special section header) and for "Additional BOOTP/DHCP Options" to come last on the page.
(cherry picked from commit 68de2169b9d5cd2878d43344a0fc0a25bd86d7af)

History

#1 Updated by Chris Buechler over 3 years ago

  • Target version changed from 2.3.1 to 2.3.2

#2 Updated by Chris Buechler over 3 years ago

  • Target version changed from 2.3.2 to 2.4.0

#3 Updated by Phillip Davis over 3 years ago

I have made 2 PRs with different ways to organize the page:
https://github.com/pfsense/pfsense/pull/3051
https://github.com/pfsense/pfsense/pull/3052

Pick one, if you like one, and close the other.

This is bit of UI crud that could easily go into 2.3.2 if you are happy.

#4 Updated by Renato Botelho over 3 years ago

  • Status changed from New to Feedback
  • Assignee changed from Steve Beaver to Renato Botelho
  • Target version changed from 2.4.0 to 2.3.2
  • % Done changed from 0 to 100

Merged, thanks Phil!

#5 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved
  • Affected Version changed from 2.3 to 2.3.x

Looks good, thanks Phil

Also available in: Atom PDF